Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: add _hosts to BaseConnection #353

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Nov 14, 2024

Allows us to access database hosts without having to work with _url_prefixes instead

@aMahanna aMahanna requested a review from apetenchea November 14, 2024 04:15
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (8e6aaca) to head (26e482a).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   95.94%   95.95%           
=======================================
  Files          26       26           
  Lines        4296     4297    +1     
=======================================
+ Hits         4122     4123    +1     
  Misses        174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aMahanna aMahanna merged commit cdf3576 into main Nov 28, 2024
37 checks passed
@aMahanna aMahanna deleted the add-hosts-to-base-connection branch November 28, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants