Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE-749 | wildcard analyzer [3.12] #324

Merged
merged 6 commits into from
Apr 24, 2024
Merged

DE-749 | wildcard analyzer [3.12] #324

merged 6 commits into from
Apr 24, 2024

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Feb 2, 2024

Can be merged after 3.12 image is introduced

tested to work locally with 3.12.0-NIGHTLY.20240305

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (d5d867c) to head (dae6107).

❗ Current head dae6107 differs from pull request most recent head 602990b. Consider uploading reports for the commit 602990b to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   98.00%   98.15%   +0.14%     
==========================================
  Files          26       26              
  Lines        4261     4219      -42     
==========================================
- Hits         4176     4141      -35     
+ Misses         85       78       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexbakharew
Copy link
Collaborator

Hi @aMahanna!
Could you please add test case for the second analyzer which we plan to release in 3.12? Here is the documentation: https://docs.arangodb.com/3.12/index-and-search/analyzers/#multi_delimiter

@aMahanna aMahanna marked this pull request as draft March 8, 2024 15:05
@aMahanna aMahanna changed the title DE-749 | test case for wildcard analyzer [3.12] DE-749 | wildcard analyzer [3.12] Mar 8, 2024
@aMahanna aMahanna marked this pull request as ready for review April 22, 2024 21:12
Copy link
Member

@apetenchea apetenchea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexbakharew once we merge this and #322 there's going to be such a test included. You probably already noticed, but I'm just mentioning this here in order to link the PRs.

@aMahanna aMahanna merged commit 851a71c into main Apr 24, 2024
1 of 35 checks passed
@aMahanna aMahanna deleted the DE-749 branch April 24, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants