-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DE-743 | MDI/ZKD Indexes #316
Conversation
(zkd & mdi indexes don't support the `sparse` property`
allows us to test with a nightly build, e.g `3.12.0-NIGHTLY.20240116`
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
==========================================
- Coverage 98.45% 98.26% -0.19%
==========================================
Files 26 26
Lines 4136 4154 +18
==========================================
+ Hits 4072 4082 +10
- Misses 64 72 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After internal discussions, this PR will be merged, but the following changes will be made to index creation:
|
Internal discussions have established that an
mdi
index is an alias for azkd
index, similar to thehash
index &persistent
index situation.Given that python-arango never had support for
zkd
index creation, this PR introduces bothadd_zkd_index
andadd_mdi_index
i.e
Ref: https://docs.arangodb.com/3.12/index-and-search/indexing/working-with-indexes/multi-dimensional-indexes/
Happy to address this in another way, perhaps there's no need for 2 methods?