-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release_candidate_changelog] CHANGELOG updates to prime for next RC.… #264
Conversation
@arangamani I'd also like to recommend we make develop the default branch so we can use git flow and build up stable code changes that will get merged to master only on version deploy, to prevent these concerns about merging to master in the future. Thoughts? |
From the comments raised and assuming every merge you've pushed in is correct. How easy is it to create a PR (Dependent on order of merges), of everything "UP TO" #192 ?? If you do that and release as a v1.6 at least it's a start, and we're then able to cut 192 and everything else as a 2.0 ? |
CHANGELOG.md
Outdated
@@ -3,6 +3,19 @@ CHANGELOG | |||
|
|||
upcoming | |||
-------- | |||
Recommendation: Breaking change is `login_with_pry` config file - it's probable this will affect people's development or testing locally but shouldn't affect production usage; I'd be comfortable with this being 1.6.0, or bumping to 2.0.0 depending on @arangamani's thoughts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's bump it to 2.0.0
. We should document how to upgrade the config file. Can you see if there is any other breaking changes we would want to introduce?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few that I can consider as candidates (purely because I like them and think they're cool :D ), but they will need to be tested and merged. I'll add this to my to-do for next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a brief skim of open PRs:
-
I'd like to get added functionality for add/delete node(s) #166 in, this line might be breaking because it changes what gets returned when creating a dumb slave, but I can look more closely to see if Jenkins is already returning true/false: https://github.com/arangamani/jenkins_api_client/pull/166/files#diff-e6faa48389a58b9287e126ac91aac0c7L259
-
adding method to get two lists 1) online nodes and 2) offline nodes #190, Implement View#list_views and View#list_views_with_details to access … #196, adding get_plugin_results method #199, adding jenkins "discard old builds" feature #203, Queue item cancel feature #205, Add in the ability to get the list of disabled jobs #214, Adds multibranch support for some functions. #237 are non-breaking and could be added as new functionality (they may need some documentation updates)
-
Enable SSL certificate verification #204 is definitely breaking and is important to add
-
Fixed view list where name of view has parenthesis #206, Encode parameters for the promote plugin API #216 are bugfixes; if people have local workarounds they may be "breaking", but are worth adding
I'm not sure if #225 and #256 are ready; I'm also not sure if Groovy script is the right way to handle this, so I would like to leave those out for a later release.
Basically, given my choice, I'd like to incorporate everything except #225 and #256 if we're going to do a version update. We can stop accepting PRs for the 2.0.0 release, and do it this way. There are also a lot of unaddressed issues that I haven't had a chance to comment on yet; if you want more breaking changes and a bigger "strategy" I can spend some more time evaluating this and come up with a bigger release. @arangamani - let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arangamani - pinging again for visibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katelovescode Let's go with your proposal and bump version and include only the well-understood PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arangamani - I will review the open PRs listed above and merge them in if they work. I'll update the changelog. What's the process for a version bump? Make a release in git tagged with the new version number and push to develop and master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, merge everything to master/develop, and then make a tag after all tests pass. Let me know when you have the tag ready, and I'll push it to rubygems.org. That part is still not automated yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will do!
… Needs @arangamani's review