Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor go.mod and re-tidy (#819) #827

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gufengwyx8
Copy link
Contributor

What this PR does:
refactor go.mod and re-tidy

Which issue(s) this PR fixes:
Fixes #819

Copy link

cr-gpt bot commented Feb 7, 2024

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b24ed9) 40.20% compared to head (773190a) 40.20%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #827   +/-   ##
=======================================
  Coverage   40.20%   40.20%           
=======================================
  Files         265      265           
  Lines       26708    26708           
=======================================
  Hits        10738    10738           
+ Misses      14826    14823    -3     
- Partials     1144     1147    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github.com/stretchr/testify v1.8.3
github.com/testcontainers/testcontainers-go v0.12.0
github.com/stretchr/testify v1.8.4
github.com/testcontainers/testcontainers-go v0.27.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade the testcontainer-go may cause the code compile error.

error file: https://github.com/arana-db/arana/blob/master/test/testcontainer_mysql.go#L62

ref: https://github.com/testcontainers/testcontainers-go/pull/386/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two dependency libraries are deleted or setting as private
3 participants