Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize show open tables xxx statment (#676) #825

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

gufengwyx8
Copy link
Contributor

What this PR does:
optimize show open tables xxx statment

Which issue(s) this PR fixes:
Fixes #676

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Copy link

cr-gpt bot commented Feb 6, 2024

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@@ -55,15 +55,34 @@ func optimizeShowOpenTables(ctx context.Context, o *optimize.Optimizer) (proto.P

tenant := rcontext.Tenant(ctx)
clusters := security.DefaultTenantManager().GetClusters(tenant)

invertedDatabases := make(map[string]string)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cap add clusters.len

Copy link
Contributor Author

@gufengwyx8 gufengwyx8 Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cap add clusters.len

this cap cannot be certain at this time, it will be the sum of all dbgroups

invertedDatabases[d] = cluster
}
}

plans := make([]proto.Plan, 0, len(clusters))
for _, cluster := range clusters {
ns := namespace.Load(tenant, cluster)
// 配置里原子库 都需要执行一次
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convert english

Copy link
Contributor Author

@gufengwyx8 gufengwyx8 Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convert english

done

Copy link

cr-gpt bot commented Feb 7, 2024

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9b24ed9) 40.20% compared to head (aa7f09e) 40.20%.

Files Patch % Lines
pkg/runtime/plan/dal/show_open_tables.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #825   +/-   ##
=======================================
  Coverage   40.20%   40.20%           
=======================================
  Files         265      265           
  Lines       26708    26708           
=======================================
  Hits        10738    10738           
+ Misses      14826    14823    -3     
- Partials     1144     1147    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongzl dongzl added the bug Something isn't working label Mar 23, 2024
@dongzl dongzl added this to the 0.3.0 milestone Mar 23, 2024
Copy link

cr-gpt bot commented Apr 10, 2024

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Copy link

cr-gpt bot commented Apr 10, 2024

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@baerwang
Copy link
Contributor

把comment 都resolve下吧 @gufengwyx8

@AlexStocks AlexStocks merged commit 325824e into arana-db:master Apr 11, 2024
11 checks passed
@gufengwyx8 gufengwyx8 deleted the fix/676 branch April 11, 2024 14:22
baerwang added a commit to baerwang/arana that referenced this pull request Sep 26, 2024
* fix: optimize show open tables xxx statment (arana-db#676) (arana-db#825)

* fix: optimize show open tables xxx statment (arana-db#676)

* fix: convert english comments (arana-db#676)

* fix: fix bug can't match any group (arana-db#676)

* Support dts to replica databases/groups (arana-db#834)

* Support dts to replica databases/groups

* feat: check dts status whether the replication task is finished

* test: misc ut (arana-db#824)

---------

Co-authored-by: null <[email protected]>
Co-authored-by: csynineyang <[email protected]>
Co-authored-by: baerwang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]Optimize show open tables xxx statment.
5 participants