-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: optimize show open tables xxx statment (#676) #825
Conversation
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
@@ -55,15 +55,34 @@ func optimizeShowOpenTables(ctx context.Context, o *optimize.Optimizer) (proto.P | |||
|
|||
tenant := rcontext.Tenant(ctx) | |||
clusters := security.DefaultTenantManager().GetClusters(tenant) | |||
|
|||
invertedDatabases := make(map[string]string) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cap add clusters.len
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cap add clusters.len
this cap cannot be certain at this time, it will be the sum of all dbgroups
invertedDatabases[d] = cluster | ||
} | ||
} | ||
|
||
plans := make([]proto.Plan, 0, len(clusters)) | ||
for _, cluster := range clusters { | ||
ns := namespace.Load(tenant, cluster) | ||
// 配置里原子库 都需要执行一次 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convert english
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convert english
done
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #825 +/- ##
=======================================
Coverage 40.20% 40.20%
=======================================
Files 265 265
Lines 26708 26708
=======================================
Hits 10738 10738
+ Misses 14826 14823 -3
- Partials 1144 1147 +3 ☔ View full report in Codecov by Sentry. |
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
Quality Gate passedIssues Measures |
把comment 都resolve下吧 @gufengwyx8 |
* fix: optimize show open tables xxx statment (arana-db#676) (arana-db#825) * fix: optimize show open tables xxx statment (arana-db#676) * fix: convert english comments (arana-db#676) * fix: fix bug can't match any group (arana-db#676) * Support dts to replica databases/groups (arana-db#834) * Support dts to replica databases/groups * feat: check dts status whether the replication task is finished * test: misc ut (arana-db#824) --------- Co-authored-by: null <[email protected]> Co-authored-by: csynineyang <[email protected]> Co-authored-by: baerwang <[email protected]>
What this PR does:
optimize show open tables xxx statment
Which issue(s) this PR fixes:
Fixes #676
Special notes for your reviewer:
Does this PR introduce a user-facing change?: