Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test cases for /pkg/util/misc #755

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Conversation

tanishasaheb15
Copy link
Contributor

@tanishasaheb15 tanishasaheb15 commented Aug 26, 2023

What this PR does:
This PR is UT for /pkg/util/misc
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.09% 🎉

Comparison is base (f285e71) 38.29% compared to head (e5d3381) 38.39%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   38.29%   38.39%   +0.09%     
==========================================
  Files         253      254       +1     
  Lines       26312    26359      +47     
==========================================
+ Hits        10076    10120      +44     
- Misses      15118    15120       +2     
- Partials     1118     1119       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanishasaheb15
Copy link
Contributor Author

@dongzl , can you please approve this workflow approval?

@dongzl
Copy link
Contributor

dongzl commented Aug 27, 2023

@dongzl , can you please approve this workflow approval?

OK

@dongzl dongzl added this to the 0.2.0 milestone Aug 27, 2023
@dongzl dongzl added the test Unit test. label Aug 27, 2023
pkg/util/misc/misc_test.go Show resolved Hide resolved
@tanishasaheb15
Copy link
Contributor Author

@dongzl , Thanks for your feedback , i have addressed the comments. can you please review it ?

@sonarcloud
Copy link

sonarcloud bot commented Aug 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tanishasaheb15
Copy link
Contributor Author

can you guys please approve the workflow so that i can merge the changes

@tanishasaheb15
Copy link
Contributor Author

@dongzl , @jjeffcaii looks like i don't have write access to this repo, so not able to merge the code changes. can you guys please help ?

@dongzl dongzl merged commit 304e9ff into arana-db:master Aug 28, 2023
12 checks passed
@dongzl
Copy link
Contributor

dongzl commented Sep 22, 2023

Hi @tanishasaheb15 , we can communicate with Slack

the invite link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Unit test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants