Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some problems when server starting #735

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

jjeffcaii
Copy link
Contributor

What this PR does:

  1. fix the starting problem
  2. adjust some logging settings
  3. bugfix: when input an illegal SQL, the session will be disconnected, and it will cause mycli reports reconnect... repeatedly forever.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Patch coverage: 9.67% and no project coverage change.

Comparison is base (3ea47a2) 36.67% compared to head (b8e958c) 36.67%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #735   +/-   ##
=======================================
  Coverage   36.67%   36.67%           
=======================================
  Files         247      247           
  Lines       26157    26157           
=======================================
  Hits         9594     9594           
  Misses      15518    15518           
  Partials     1045     1045           
Files Changed Coverage Δ
pkg/config/model.go 34.45% <ø> (ø)
pkg/executor/redirect.go 3.75% <0.00%> (ø)
pkg/runtime/namespace/command.go 16.27% <0.00%> (ø)
pkg/config/misc.go 16.12% <40.00%> (ø)
pkg/boot/boot.go 45.66% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongzl dongzl added refactor Refactor code enhancement New feature or request labels Aug 14, 2023
@dongzl dongzl added this to the 0.2.0 milestone Aug 14, 2023
@jjeffcaii jjeffcaii force-pushed the fix/cannot_startup branch 2 times, most recently from a741239 to 8b82c96 Compare August 14, 2023 11:27
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
11.7% 11.7% Duplication

@dongzl dongzl merged commit b9526c8 into arana-db:master Aug 15, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants