Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): add unit test for cast function #723

Merged
merged 7 commits into from
Jul 27, 2023

Conversation

dongzl
Copy link
Contributor

@dongzl dongzl commented Jul 26, 2023

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@dongzl dongzl added this to the 0.2.0 milestone Jul 26, 2023
@dongzl dongzl changed the title feat(test): add unit test for cast function [WIP] feat(test): add unit test for cast function Jul 26, 2023
@dongzl dongzl added the test Unit test. label Jul 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.26% ⚠️

Comparison is base (d085199) 36.44% compared to head (6deb6c9) 36.18%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
- Coverage   36.44%   36.18%   -0.26%     
==========================================
  Files         246      246              
  Lines       26100    26100              
==========================================
- Hits         9511     9445      -66     
- Misses      15505    15601      +96     
+ Partials     1084     1054      -30     
Files Changed Coverage Δ
pkg/runtime/function/cast_time.go 85.20% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongzl dongzl changed the title [WIP] feat(test): add unit test for cast function feat(test): add unit test for cast function Jul 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dongzl dongzl merged commit a6636b7 into arana-db:master Jul 27, 2023
12 checks passed
@dongzl dongzl deleted the func-unit-test branch July 28, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Unit test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants