Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for /arana/pkg/config #722

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

gongna-au
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #707

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
29.9% 29.9% Duplication

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.51 🎉

Comparison is base (0457c45) 37.28% compared to head (cf8ebc0) 37.79%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
+ Coverage   37.28%   37.79%   +0.51%     
==========================================
  Files         230      230              
  Lines       24460    24460              
==========================================
+ Hits         9120     9245     +125     
+ Misses      14296    14192     -104     
+ Partials     1044     1023      -21     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dongzl dongzl added the test Unit test. label Jul 24, 2023
@dongzl dongzl added this to the 0.2.0 milestone Jul 24, 2023
@AlexStocks AlexStocks merged commit d085199 into arana-db:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Unit test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test] add unit test for /arana/pkg/config.
4 participants