Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 修改show index #719

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

PangXing
Copy link
Contributor

What this PR does:
image

Which issue(s) this PR fixes:

Fixes #678

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (0457c45) 37.28% compared to head (227f91b) 37.31%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
+ Coverage   37.28%   37.31%   +0.02%     
==========================================
  Files         230      230              
  Lines       24460    24578     +118     
==========================================
+ Hits         9120     9171      +51     
- Misses      14296    14379      +83     
+ Partials     1044     1028      -16     
Impacted Files Coverage Δ
pkg/dataset/sort_merge_join.go 75.47% <ø> (+7.67%) ⬆️
pkg/runtime/plan/dal/show_index.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dongzl dongzl added the bug Something isn't working label Jul 22, 2023
@dongzl dongzl added this to the 0.2.0 milestone Jul 22, 2023
"github.com/stretchr/testify/assert"

"go.uber.org/atomic"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 41a2fbd into arana-db:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] fix SHOW INDEXES FROM xxx result error
5 participants