Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support HashJoin For Shards #656

Closed
wants to merge 19 commits into from
Closed

[Feature] Support HashJoin For Shards #656

wants to merge 19 commits into from

Conversation

huangwenkan9
Copy link
Contributor

@huangwenkan9 huangwenkan9 commented Mar 19, 2023

目前支持简单的跨库hashjoin功能:
比如 SELECT * FROM student JOIN salaries ON student.id = salaries.emp_on;,其中student是分片表

持续迭代支持复杂的情况TODO:

  • 支持多个嵌套的复杂select sql查询;
  • 支持dateset上复杂的条件where或排序;
  • 支持left/right join等sql;
  • ...

涉及改动:

  • optimizeJoin()支持跨库查;
  • 新增HashJoinPlan

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Patch coverage: 11.16% and no project coverage change.

Comparison is base (c95f464) 36.42% compared to head (a493b18) 36.42%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #656   +/-   ##
=======================================
  Coverage   36.42%   36.42%           
=======================================
  Files         228      228           
  Lines       23761    23761           
=======================================
  Hits         8655     8655           
  Misses      14107    14107           
  Partials      999      999           
Impacted Files Coverage Δ
pkg/runtime/optimize/dml/select.go 0.45% <0.00%> (ø)
pkg/runtime/ast/expression.go 23.68% <14.28%> (ø)
pkg/runtime/ast/select_element.go 17.12% <16.66%> (ø)
pkg/runtime/ast/expression_atom.go 33.63% <32.00%> (ø)
pkg/runtime/ast/predicate.go 37.00% <52.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dongzl dongzl added the kernel kernel label Mar 21, 2023
@dongzl dongzl added this to the 0.3.0 milestone Mar 21, 2023
Copy link
Contributor

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a big PR, unit tests should be added. thx.

@huangwenkan9 huangwenkan9 changed the title [WIP] Support HashJoin Feature [Feature] Support HashJoin For Shards Jun 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
8.6% 8.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
8.6% 8.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@huangwenkan9 huangwenkan9 closed this by deleting the head repository Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants