chore: add a testing valuer which always returns an error (#724)

arana-db · Jul 28, 2023 · 69019ed · 69019ed
1 parent a6636b7
commit 69019ed
Show file tree

Hide file tree

Showing 20 changed files with 83 additions and 282 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -26,7 +26,7 @@ repos:
       - id: end-of-file-fixer
       - id: trailing-whitespace
   - repo: https://github.com/tekwizely/pre-commit-golang
-    rev: v1.0.0-beta.5
+    rev: v1.0.0-rc.1
     hooks:
       - id: my-cmd-mod
         name: imports-formatter

diff --git a/go.mod b/go.mod
@@ -66,7 +66,6 @@ require (
 	github.com/docker/distribution v2.7.1+incompatible // indirect
 	github.com/docker/docker v20.10.11+incompatible // indirect
 	github.com/docker/go-connections v0.4.0 // indirect
-	github.com/dubbogo/tools v1.0.9 // indirect
 	github.com/dustin/go-humanize v1.0.0 // indirect
 	github.com/gin-contrib/sse v0.1.0 // indirect
 	github.com/go-errors/errors v1.0.1 // indirect

diff --git a/go.sum b/go.sum
diff --git a/pkg/config/diff_test.go b/pkg/config/diff_test.go
@@ -347,7 +347,6 @@ func TestDataSourceClusterDiff(t *testing.T) {
 }
 
 func TestGroupsDiff(t *testing.T) {
-
 	oldGroups := Groups{
 		&Group{
 			Name:  "group1",

diff --git a/pkg/config/event_test.go b/pkg/config/event_test.go
@@ -18,7 +18,9 @@
 
 package config
 
-import "testing"
+import (
+	"testing"
+)
 
 func TestEventTypes(t *testing.T) {
 	tests := []struct {

diff --git a/pkg/proto/function.go b/pkg/proto/function.go
@@ -68,6 +68,14 @@ func (f FuncValuer) Value(ctx context.Context) (Value, error) {
 	return f(ctx)
 }
 
+type alwaysErrorValuer struct {
+	err error
+}
+
+func (a alwaysErrorValuer) Value(ctx context.Context) (Value, error) {
+	return nil, a.err
+}
+
 type directValuer struct {
 	v Value
 }
@@ -76,6 +84,15 @@ func (t directValuer) Value(ctx context.Context) (Value, error) {
 	return t.v, nil
 }
 
+// ToValuerWithError returns a Valuer which always returns an error.
+// NOTICE: we don't usually use this method, it's only for testing!
+func ToValuerWithError(err error) Valuer {
+	if err == nil {
+		panic("the ToValuerWithError only accept non-nil error!")
+	}
+	return alwaysErrorValuer{err: err}
+}
+
 // ToValuer wraps Value to Valuer directly.
 func ToValuer(value Value) Valuer {
 	return directValuer{v: value}

diff --git a/pkg/runtime/function/first_value_test.go b/pkg/runtime/function/first_value_test.go
@@ -40,7 +40,7 @@ func TestFuncFirstValue(t *testing.T) {
 	for _, v := range []tt{
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -56,7 +56,7 @@ func TestFuncFirstValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -72,7 +72,7 @@ func TestFuncFirstValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:30:00"), proto.NewValueString("st113"), proto.NewValueFloat64(25)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -88,7 +88,7 @@ func TestFuncFirstValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:45:00"), proto.NewValueString("st113"), proto.NewValueFloat64(0)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -104,7 +104,7 @@ func TestFuncFirstValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:00:00"), proto.NewValueString("xh458"), proto.NewValueFloat64(0)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -120,7 +120,7 @@ func TestFuncFirstValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:15:00"), proto.NewValueString("xh458"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -136,7 +136,7 @@ func TestFuncFirstValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:30:00"), proto.NewValueString("xh458"), proto.NewValueFloat64(5)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -152,7 +152,7 @@ func TestFuncFirstValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:45:00"), proto.NewValueString("xh458"), proto.NewValueFloat64(30)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -168,7 +168,7 @@ func TestFuncFirstValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("08:00:00"), proto.NewValueString("xh458"), proto.NewValueFloat64(25)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},

diff --git a/pkg/runtime/function/lag_test.go b/pkg/runtime/function/lag_test.go
@@ -40,7 +40,7 @@ func TestFuncLag(t *testing.T) {
 	for _, v := range []tt{
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueInt64(1)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},
@@ -55,7 +55,7 @@ func TestFuncLag(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueInt64(1)},
 				{proto.NewValueString("13:00:00"), proto.NewValueString(""), proto.NewValueFloat64(125)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},
@@ -70,7 +70,7 @@ func TestFuncLag(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueInt64(1)},
 				{proto.NewValueString("14:00:00"), proto.NewValueString(""), proto.NewValueFloat64(132)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},
@@ -85,7 +85,7 @@ func TestFuncLag(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueInt64(1)},
 				{proto.NewValueString("15:00:00"), proto.NewValueString(""), proto.NewValueFloat64(145)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},
@@ -100,7 +100,7 @@ func TestFuncLag(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueInt64(1)},
 				{proto.NewValueString("16:00:00"), proto.NewValueString(""), proto.NewValueFloat64(140)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},
@@ -115,7 +115,7 @@ func TestFuncLag(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueInt64(1)},
 				{proto.NewValueString("17:00:00"), proto.NewValueString(""), proto.NewValueFloat64(150)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},
@@ -130,7 +130,7 @@ func TestFuncLag(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueInt64(1)},
 				{proto.NewValueString("18:00:00"), proto.NewValueString(""), proto.NewValueFloat64(200)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},

diff --git a/pkg/runtime/function/last_value_test.go b/pkg/runtime/function/last_value_test.go
@@ -40,7 +40,7 @@ func TestFuncLastValue(t *testing.T) {
 	for _, v := range []tt{
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -56,7 +56,7 @@ func TestFuncLastValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -72,7 +72,7 @@ func TestFuncLastValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:30:00"), proto.NewValueString("st113"), proto.NewValueFloat64(25)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -88,7 +88,7 @@ func TestFuncLastValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:45:00"), proto.NewValueString("st113"), proto.NewValueFloat64(0)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -104,7 +104,7 @@ func TestFuncLastValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:00:00"), proto.NewValueString("xh458"), proto.NewValueFloat64(0)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -120,7 +120,7 @@ func TestFuncLastValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:15:00"), proto.NewValueString("xh458"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -136,7 +136,7 @@ func TestFuncLastValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:30:00"), proto.NewValueString("xh458"), proto.NewValueFloat64(5)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -152,7 +152,7 @@ func TestFuncLastValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("07:45:00"), proto.NewValueString("xh458"), proto.NewValueFloat64(30)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},
@@ -168,7 +168,7 @@ func TestFuncLastValue(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueString("08:00:00"), proto.NewValueString("xh458"), proto.NewValueFloat64(25)},
 				{proto.NewValueString("07:00:00"), proto.NewValueString("st113"), proto.NewValueFloat64(10)},
 				{proto.NewValueString("07:15:00"), proto.NewValueString("st113"), proto.NewValueFloat64(9)},

diff --git a/pkg/runtime/function/lead_test.go b/pkg/runtime/function/lead_test.go
@@ -40,7 +40,7 @@ func TestFuncLead(t *testing.T) {
 	for _, v := range []tt{
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueInt64(1)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},
@@ -55,7 +55,7 @@ func TestFuncLead(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueInt64(1)},
 				{proto.NewValueString("13:00:00"), proto.NewValueString(""), proto.NewValueFloat64(125)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},
@@ -70,7 +70,7 @@ func TestFuncLead(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueInt64(1)},
 				{proto.NewValueString("14:00:00"), proto.NewValueString(""), proto.NewValueFloat64(132)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},
@@ -85,7 +85,7 @@ func TestFuncLead(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueInt64(1)},
 				{proto.NewValueString("15:00:00"), proto.NewValueString(""), proto.NewValueFloat64(145)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},
@@ -100,7 +100,7 @@ func TestFuncLead(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueInt64(1)},
 				{proto.NewValueString("16:00:00"), proto.NewValueString(""), proto.NewValueFloat64(140)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},
@@ -115,7 +115,7 @@ func TestFuncLead(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueInt64(1)},
 				{proto.NewValueString("17:00:00"), proto.NewValueString(""), proto.NewValueFloat64(150)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},
@@ -130,7 +130,7 @@ func TestFuncLead(t *testing.T) {
 		},
 		{
 			[][]proto.Value{
-				//order column, partition column, value column
+				// order column, partition column, value column
 				{proto.NewValueInt64(1)},
 				{proto.NewValueString("18:00:00"), proto.NewValueString(""), proto.NewValueFloat64(200)},
 				{proto.NewValueString("12:00:00"), proto.NewValueString(""), proto.NewValueFloat64(100)},