Skip to content

Commit

Permalink
fix: Correctly mark peer-dependencies as external dependencies, disab…
Browse files Browse the repository at this point in the history
…le export of module components (#125)
  • Loading branch information
cgero-eth authored Mar 13, 2024
1 parent f25cea5 commit d976280
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Fixed

- Fix library build to avoid bundling peer dependencies
- Remove export of module components until the Aragon App migrates to Wagmi v2

## [1.0.19] - 2024-03-13

### Added
Expand Down
2 changes: 1 addition & 1 deletion rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ module.exports = [
plugins: [analyze ? visualizer({ filename: 'stats.cjs.html', open: true }) : undefined],
},
],
external: Object.keys(package.dependencies),
external: [...Object.keys(package.dependencies), ...Object.keys(package.peerDependencies)],
plugins: [
// Locate and resolve node modules
nodeResolve(),
Expand Down
5 changes: 4 additions & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
export * from './core';
export * from './modules';
// Temporarily disable modules component export as Aragon App will throw error when trying to import components from
// the ODS library. The error is caused by the ODS build because it imports the WagmiProvider that is not implemented
// on Wagmi v1. Enable modules component export when Aragon App migrates to Wagmi v2 (https://aragonassociation.atlassian.net/browse/APP-2949)
// export * from './modules';

0 comments on commit d976280

Please sign in to comment.