fix(misconf): properly expand dynamic blocks #7612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikpivkin <[email protected]>
6 tasks
Signed-off-by: nikpivkin <[email protected]>
nikpivkin
commented
Oct 7, 2024
| @@ -567,7 +567,7 @@ resource "something" "else" { | |||
| for_each = toset(["true"]) | |||
|
|
|||
| content { | |||
| ok = each.value | |||
| ok = blah.value | |||
There was a problem hiding this comment.
For reviewers: this test should not have run successfully because dynamic blocks do not create an each object.
simar7
reviewed
Oct 17, 2024
simar7
reviewed
Oct 17, 2024
simar7
reviewed
Oct 17, 2024
simar7
reviewed
Oct 17, 2024
Signed-off-by: nikpivkin <[email protected]>
simar7
reviewed
Oct 17, 2024
pkg/iac/terraform/block.go
Outdated
Comment on lines
694
to
696
| if forEachVal.IsNull() || !forEachVal.IsKnown() { | ||
| return cty.NilVal, errors.New("cannot use a null or unknown value in for_each") | ||
| } |
There was a problem hiding this comment.
In my coverage this seems to be untested so I decided to investigate. Would this ever be reached since we already check for !forEachVal.CanIterateElements() prior to this? If you have a sample input, it'd be nice to understand.
There was a problem hiding this comment.
Yes, this check is unreachable, I removed it. 4d3de2a
Signed-off-by: nikpivkin <[email protected]>
simar7
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR separates the logic for expanding dynamic blocks from expanding the
for-eachmeta argument.Related issues
Checklist