Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: enhancing documentation for trivyignore #4814

Closed

Conversation

AnaisUrlichs
Copy link
Contributor

There were some comments asking for better documentation on how to set up the trivyignore file

@@ -215,6 +215,12 @@ generic-unwanted-rule
aws-account-id
```

For a container image, such as the one used below, follow these steps to add a vulnerability to the `trivyignore` file:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of comments did we get? It just adds CVE-ID to .trivyignore. Why do we want to navigate users to AVD?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well people were pointing out that the steps are not documented -- so without documentation I cannot know what is wrong with the existing documentation -- if you think this is unnecessary, then we can leave it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if they wanted to know how to ignore misconfiguration findings. Ignoring vulnerabilities is too simple. When CVE-2019-1563 is detected, and they want to ignore it, they just add it to .trivyignore. There are no special steps to explain.

We should clarify what is unclear for people in our documentation.

@AnaisUrlichs
Copy link
Contributor Author

Closing this pull request for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants