Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support concurrent agent runs by checking if Trivy is installed #17

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joaoacmota
Copy link

@joaoacmota joaoacmota commented Oct 21, 2022

Please review, as it addresses and closes #15

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2022

CLA assistant check
All committers have signed the CLA.

@a-poluyanov
Copy link

a-poluyanov commented Sep 14, 2024

Friend, I like your proposal, and I even created an issue on this topic. But you need to improve it. You check if the banary file exists before uploading here

const installedAlready = task.exist(localPath + "/" + artifact)
    if (installedAlready) 

But your code does not take into account that if I downloaded version 0.55.0 and then changed the version to 0.55.1 in my pipeline, it will skip the download and use the old version, this is not correct and can break the logic that the developer intended.

const versionFilePath = path.join(localPath, "trivy_version.txt");

I can help you refine it if you want, I suggest accepting this change after successful refinement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concurrency issue using the trivy binary directly
3 participants