Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HDR temporarily #2

Closed
wants to merge 2 commits into from
Closed

Conversation

Nonta72
Copy link

@Nonta72 Nonta72 commented Dec 25, 2017

Taken from https://github.com/aquaris-dev/proprietary_vendor_bq/tree/cm-14.1/vegetalte

Fixes HDR in some camera apps:

  • BQ Camera 4.5.2 signed = OK
  • Google Camera 2.7 = OK
  • Lenovo SnapIt 5.8 = OK
  • Snap Camera = NOT WORKING (takes double pictures).

Taken from https://github.com/aquaris-dev/proprietary_vendor_bq/tree/cm-14.1/vegetalte
* Fixes HDR in somes camera apps: *
- BQ Camera 4.5.2 signed = OK
- Google Camera 2.7 = OK
- Lenovo SnapIt 5.8 = OK
- Snap Camera = NOT WORKING (takes double pictures).
@Nonta72
Copy link
Author

Nonta72 commented Dec 25, 2017

Slowmotion is still broken in BQ Camera

@stucki
Copy link

stucki commented Jan 2, 2018

Using the blobs from a different device will probably have new implications. I prefer to fix the root of the problem. See aquaris-dev/android_device_bq_gohan#9

@Nonta72
Copy link
Author

Nonta72 commented Jan 2, 2018

Yeah, it's never a good idea.
But HDR was fixed at some point in CM/LOS13 using blobs from kipper.
So, I'd say this fix is better than nothing. It's not final of course, that's why I used "Temporary".
We will try when BQ releases OFFICIAL Nougat for this device.

Imported from 5.0.0 release.
Thanks @vasco Machado
@eloimuns
Copy link
Member

I do not agree this changes.

We will upgrade tree/blobs/kernel to 5.0.0 so "it should be fixed" at this point.

@Nonta72
Copy link
Author

Nonta72 commented Jan 21, 2018

As you wish.

@Nonta72 Nonta72 closed this Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants