Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kubernetes/kubectl): add exe file extension for windows #30398

Closed
wants to merge 1 commit into from

Conversation

ChipWolf
Copy link
Contributor

Check List

Ensures the .exe file extension is used for windows installations

@ChipWolf
Copy link
Contributor Author

image

@suzuki-shunsuke
Copy link
Member

Probably it's the issue of mise, not aqua.
By default aqua automatically complements .exe on Windows.

@suzuki-shunsuke
Copy link
Member

I close this pr.
Please reopen it if you want.

@ChipWolf
Copy link
Contributor Author

ChipWolf commented Dec 29, 2024

Probably it's the issue of mise, not aqua. By default aqua automatically complements .exe on Windows.

It 404s on the URL without this change @suzuki-shunsuke, it may be a mise issue, I'll re-raise the PR with just the URL change for now.

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Dec 29, 2024

@ChipWolf Do you use aqua, not mise?
If so, could you tell me how to reproduce the issue?

  • aqua version
  • environment
  • command
  • output

@suzuki-shunsuke
Copy link
Member

At least, aqua could install kubectl well on Windows in CI.

So I can't find any issue.

@suzuki-shunsuke
Copy link
Member

I wrote a note for mise users:

I close this pr again because I don't think this is a problem of this package.
If aqua doesn't complement .exe on Windows, I guess it's a bug of aqua, not aqua-registry.
So in that case please create an issue to aqua.

According to the screen shot, you use mise, not aqua. #30398 (comment)
If you can reproduce the issue using mise but you can't reproduce the issue using aqua, it isn't an issue of aqua.
In that case, we can't help you. Please ask mise community for help.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants