Add multisig account support #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
force-pushed
the
multisig_account_support
branch
from
d36ee2d
to
7ed08ec
Compare
0xmaayan
force-pushed
the
multisig_account_support
branch
from
7ed08ec
to
80e5c33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A multisig account on Aptos (aka multisig account v2) doesnt have a publicKey, therefore a multisig wallet is blocked by the required publicKey prop in the standard.
This PR introduces a new
AptosWalletMultiSigAccountinterface to implement.Note that I decided to go with a new interface and a
isMultiSigAccountproperty instead of making the publicKey property optional on the existing interface as the two accounts are logically different and it makes more sense to treat them as different accounts and also for a better dev exp where the end dev doesnt need to consistently check the type/instance of the account and prevent build mismatch.