Fix navigation and formatting in Build -> Smart Contracts (Move) -> Objects #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
igor-p
commented
Oct 25, 2024
Comment on lines
26
to
27
| objects: { | ||
| title: "Object", | ||
| "aptos-objects": { | ||
| title: "Objects", |
There was a problem hiding this comment.
I tried keeping this route as objects, but if you go to https://aptos.dev/en/build/smart-contracts/objects/creating-objects and hit refresh, it redirects to using-objects and I'm not sure why. Changing the name of the route to something other than objects fixes it though.
There was a problem hiding this comment.
Maybe there's a permalink in the redirects. A lot of them are set as permanent.
igor-p
force-pushed
the
igor/fix-build-SC-objects-pages
branch
from
b1b772d
to
db28fab
Compare
igor-p
force-pushed
the
igor/fix-build-SC-objects-pages
branch
from
db28fab
to
197e84e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On https://aptos.dev/en/build/smart-contracts/objects/creating-objects, the sidebar table of contents is broken (due to the wrong headings used in the
mdxfile). This fixes the ToC and ensures correct headings are used.Another issue is that routing to the
Objectspage under theAddressable Storagesection is broken. On clicking it, the page will navigate correctly, but the sidebar shows you inObjectunderAptos Standards(they both useobjectsas the route). This fixes that issue by usingobjectpath for the route under "Aptos Standards" andmove-objectsfor the route under "Addressable Storage".I added redirects for the old routes.
Screen.Recording.2024-10-25.at.2.21.06.PM.mov
Checklist
pnpm spellcheck?pnpm fmt?pnpm lint?