Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new telegram template to cad #581

Merged
merged 14 commits into from
Sep 11, 2024
Merged

Conversation

0xaptosj
Copy link
Contributor

@0xaptosj 0xaptosj commented Sep 3, 2024

Description

Checklist

  • Do all Lints pass?
    • Have you ran pnpm spellcheck?
    • Have you ran pnpm fmt?
    • Have you ran pnpm lint?

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 7:18pm

@0xaptosj 0xaptosj changed the title Add 2 new telegram templates to cad Add two new telegram templates to cad Sep 3, 2024
Copy link
Contributor

@0xmaayan 0xmaayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge following comments on aptos-labs/create-aptos-dapp#196 (review)

@0xaptosj 0xaptosj force-pushed the j/add-telegram-template-to-cad branch from 9900ce3 to 7814f3e Compare September 4, 2024 22:15
@0xaptosj 0xaptosj force-pushed the j/add-telegram-template-to-cad branch from 7814f3e to 1634348 Compare September 9, 2024 22:36
@0xaptosj 0xaptosj changed the title Add two new telegram templates to cad Add two telegram templates to cad Sep 9, 2024
@0xaptosj 0xaptosj changed the title Add two telegram templates to cad Add new telegram templates to cad Sep 9, 2024
@0xaptosj 0xaptosj changed the title Add new telegram templates to cad Add new telegram template to cad Sep 9, 2024
Copy link
Contributor

@0xmaayan 0xmaayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. But we need to wait with merging it until a new CAD version is out.

Adding the "do not merge" label

Copy link
Collaborator

@hariria hariria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please condense the commits to 1 commit

@0xaptosj 0xaptosj merged commit 1c43bef into main Sep 11, 2024
5 checks passed
@0xaptosj 0xaptosj deleted the j/add-telegram-template-to-cad branch September 11, 2024 19:30
@0xaptosj
Copy link
Contributor Author

Please condense the commits to 1 commit

yes it got auto squashed at merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants