Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for FA processor #546

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Documentation for FA processor #546

wants to merge 1 commit into from

Conversation

rtso
Copy link
Collaborator

@rtso rtso commented Oct 9, 2024

No description provided.

@rtso rtso changed the title add documentation Documentation for FA processor Oct 9, 2024
Copy link
Collaborator Author

rtso commented Oct 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rtso and the rest of your teammates on Graphite Graphite

@rtso rtso requested review from bowenyang007 and a team October 9, 2024 21:17
@rtso rtso marked this pull request as ready for review October 9, 2024 21:17
@@ -394,6 +394,7 @@ impl FungibleAssetBalance {
last_transaction_timestamp: txn_timestamp,
token_standard: TokenStandard::V1.to_string(),
};
// What is this for?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V1 events don't have asset type. It's just "0x1::coin::WithdrawEvent" (or something like that) w/ the address and amount of APT.

Copy link
Collaborator

@bowenyang007 bowenyang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the comments, should we also summarize this in a doc somewhere? We could also add this to dev docs post migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants