Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gha/docker] build with branch name; also cleanup #538

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

rustielin
Copy link
Contributor

@rustielin rustielin commented Oct 3, 2024

Builds off of special branches like main get image tags now in the form:

  • <branch_name>
  • <branch_name>_<git_sha>

This is useful for Forge, which by default should use the latest stable processors version. Currently it's pinned to some recent commit hash

Also general cleanup of branch push triggers

Test plan

Canary runs on push to PR branch. It pushes all the expected tags

INFO[0237] Pushing image to us-docker.pkg.dev/aptos-registry/docker/indexer-client-examples/rust:dbd773c4d0c6c4bac21bc210dadd87eb0b11863c 
INFO[0240] Pushed us-docker.pkg.dev/aptos-registry/docker/indexer-client-examples/rust@sha256:6776a413b25dd4ec6a632a34719376ff36366e192f2999c4704d2b3200431481 
INFO[0240] Pushing image to us-docker.pkg.dev/aptos-registry/docker/indexer-client-examples/rust:rustielin-branch-prefix-build 
INFO[0241] Pushed us-docker.pkg.dev/aptos-registry/docker/indexer-client-examples/rust@sha256:6776a413b25dd4ec6a632a34719376ff36366e192f2999c4704d2b3200431481 
INFO[0241] Pushing image to us-docker.pkg.dev/aptos-registry/docker/indexer-client-examples/rust:rustielin-branch-prefix-build_dbd773c4d0c6c4bac21bc210dadd87eb0b11863c 
INFO[0242] Pushed us-docker.pkg.dev/aptos-registry/docker/indexer-client-examples/rust@sha256:6776a413b25dd4ec6a632a34719376ff36366e[192](https://github.com/aptos-labs/aptos-indexer-processors/actions/runs/11168000083/job/31045425474?pr=538#step:5:193)f2999c4704d2b3200431481

And it's in GAR

image

@rustielin rustielin force-pushed the rustielin/branch-prefix-build branch 2 times, most recently from 829bb24 to dbd773c Compare October 3, 2024 18:57
@rustielin rustielin marked this pull request as ready for review October 3, 2024 19:03
@rustielin rustielin requested review from bowenyang007, larry-aptos and a team October 3, 2024 19:03
@rustielin rustielin force-pushed the rustielin/branch-prefix-build branch from dbd773c to 2836bd4 Compare October 3, 2024 19:04
@igor-aptos
Copy link

how do you define: "latest stable processors version" ?

is that just latest built from main, or something else?

@rustielin
Copy link
Contributor Author

For now it's just the latest built from main. Since main is where we cut our releases from for processors, and there's no branching strategy for release, this is generally assumed safe.

For tests we could also consider using the latest release version (by tag)

@rustielin rustielin requested a review from a team October 4, 2024 18:25
Copy link

@sionescu sionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@rustielin rustielin merged commit a99fdc3 into main Oct 4, 2024
7 checks passed
@rustielin rustielin deleted the rustielin/branch-prefix-build branch October 4, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants