Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update commit hash for imported txn #536

Merged
merged 2 commits into from
Oct 3, 2024
Merged

update commit hash for imported txn #536

merged 2 commits into from
Oct 3, 2024

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Oct 3, 2024

Description

update the aptos-indexer-test-transactions dependency.

it was causing the workflow failed when it's triggered with the latest change from aptos-core. because the test was referring to the old const variable, which was deprecated.
failed job: https://github.com/aptos-labs/aptos-indexer-processors/actions/runs/11155221954/job/31005811598

@yuunlimm yuunlimm marked this pull request as ready for review October 3, 2024 04:40
@yuunlimm yuunlimm requested review from a team, just-in-chang and larry-aptos October 3, 2024 04:41
Copy link
Collaborator

@larry-aptos larry-aptos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

let's put the json diff with config as the follow-up.

@yuunlimm yuunlimm merged commit b5af971 into main Oct 3, 2024
7 checks passed
@yuunlimm yuunlimm deleted the yuunlimm/update-tests branch October 3, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants