Boolean Logic Transaction Filtering #392
Conversation
CapCap
force-pushed
the
transaction_filter_simple
branch
from
2a41972
to
c73f38f
Compare
CapCap
force-pushed
the
transaction_filter_simple
branch
from
c73f38f
to
236b94d
Compare
| } | ||
| } | ||
|
|
||
| impl Filterable<i32> for Option<i32> { |
There was a problem hiding this comment.
We use i64 in most places in the processors, should we use i64 here too?
|
|
||
| #[inline] | ||
| fn is_allowed(&self, struct_tag: &MoveStructTag) -> bool { | ||
| self.address.is_allowed(&struct_tag.address) |
There was a problem hiding this comment.
Does it expect that the address is 64 length? Should we support both truncated and standardized addresses?
There was a problem hiding this comment.
it does expect standardized addresses, yeah... I was hoping this could be a convention, but we could also put it in custom serde?
| /// This is a wrapper around ChangeItemFilter, which differs because: | ||
| /// While `ChangeItemFilter` will return false if the Event does not match the filter, | ||
| /// `ChangeItemFilter` will return true- i.e `WriteSetChangeFilter` *only* tries to match if the | ||
| /// change type matches its internal change type |
There was a problem hiding this comment.
Do we need both the ChangeItemFilter and WriteSetChangeFilter? If it's possible, I prefer having a single one to keep things simpler.
Also how will we check a transaction if a transaction is allowed? Is it if any of its wsc is allowed?
There was a problem hiding this comment.
currently this simple version- yeah
In the follow up PR, there is a AND, OR, and NOT
CapCap
changed the title
an MVP version of the transaction filtering crate
Performance
On a random 3mb proto of 1000txns during taptos, running the "everything" filter (looped) gives:
Random 10mb proto from April 25th with "everything" filter:
Graffio 100mb proto ("everything" filter, but with
or):