Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler-v2] Fix test plan in move-unit-test to use compiler v2 #15388

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rahxephon89
Copy link
Contributor

@rahxephon89 rahxephon89 commented Nov 25, 2024

Description

This PR closes #15385 by explicitly using test plan builder v2 in move-unit-test when MOVE_COMPILER_V2 is set to true.

How Has This Been Tested?

Existing test cases in move-unit-test, see updated baseline files.

Key Areas to Review

Whether flags are correctly set when running tests using Compiler v2.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 25, 2024

⏱️ 33m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 13m 🟩
rust-move-tests 12m 🟩
rust-cargo-deny 4m 🟩🟩
check-dynamic-deps 1m 🟩🟩
general-lints 53s 🟩🟩
semgrep/ci 53s 🟩🟩
file_change_determinator 20s 🟩🟩
permission-check 8s 🟩🟩
permission-check 6s 🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@rahxephon89 rahxephon89 changed the title [WIP][Compiler-v2] Fix test plan builder in move-unit-test to use compiler v2 [WIP][Compiler-v2] Fix test plan in move-unit-test to use compiler v2 Nov 25, 2024
@rahxephon89 rahxephon89 changed the title [WIP][Compiler-v2] Fix test plan in move-unit-test to use compiler v2 [Compiler-v2] Fix test plan in move-unit-test to use compiler v2 Nov 25, 2024
@rahxephon89 rahxephon89 marked this pull request as ready for review November 25, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][compiler-v2] Tests running for "move-unit-test" package are not using compiler v2
1 participant