Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Verify consensus message author matches with the sender #15386

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vusirikala
Copy link
Contributor

@vusirikala vusirikala commented Nov 24, 2024

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 24, 2024

⏱️ 56m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
forge-compat-test / forge 16m 🟩
rust-move-tests 12m 🟩
rust-doc-tests 5m 🟩
test-target-determinator 4m 🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
rust-cargo-deny 3m 🟩
check-dynamic-deps 2m 🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
general-lints 54s 🟩🟩
semgrep/ci 54s 🟩🟩
rust-move-tests 31s
file_change_determinator 21s 🟩🟩
file_change_determinator 10s 🟩
execution-performance / single-node-performance 10s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 16m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@vusirikala vusirikala requested review from manudhundi and danielxiangzl and removed request for sasha8 November 24, 2024 23:50
@vusirikala vusirikala enabled auto-merge (squash) November 24, 2024 23:51

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 11b5b0a12f415ad24250b2e3e8e0af74af9be33a

two traffics test: inner traffic : committed: 14083.08 txn/s, latency: 2821.18 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3600 ms), latency samples: 5354700
two traffics test : committed: 99.99 txn/s, latency: 1786.59 ms, (p50: 1400 ms, p70: 1500, p90: 1900 ms, p99: 9900 ms), latency samples: 1660
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.499, avg: 1.541", "ConsensusProposalToOrdered: max: 0.317, avg: 0.292", "ConsensusOrderedToCommit: max: 0.381, avg: 0.369", "ConsensusProposalToCommit: max: 0.674, avg: 0.661"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.06s no progress at version 2547613 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.49s no progress at version 2547609 (avg 15.49s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 11b5b0a12f415ad24250b2e3e8e0af74af9be33a

Compatibility test results for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 11b5b0a12f415ad24250b2e3e8e0af74af9be33a (PR)
Upgrade the nodes to version: 11b5b0a12f415ad24250b2e3e8e0af74af9be33a
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1411.13 txn/s, submitted: 1415.09 txn/s, failed submission: 3.96 txn/s, expired: 3.96 txn/s, latency: 2098.38 ms, (p50: 1800 ms, p70: 2100, p90: 3300 ms, p99: 4500 ms), latency samples: 128280
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1602.99 txn/s, submitted: 1605.49 txn/s, failed submission: 2.50 txn/s, expired: 2.50 txn/s, latency: 2105.87 ms, (p50: 2100 ms, p70: 2400, p90: 3100 ms, p99: 3900 ms), latency samples: 128260
5. check swarm health
Compatibility test for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 11b5b0a12f415ad24250b2e3e8e0af74af9be33a passed
Upgrade the remaining nodes to version: 11b5b0a12f415ad24250b2e3e8e0af74af9be33a
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1393.12 txn/s, submitted: 1395.10 txn/s, failed submission: 1.99 txn/s, expired: 1.99 txn/s, latency: 2135.64 ms, (p50: 2100 ms, p70: 2100, p90: 3100 ms, p99: 5000 ms), latency samples: 126300
Test Ok

@vusirikala vusirikala changed the title Verify consensus message author matches with the sender [Draft] Verify consensus message author matches with the sender Nov 25, 2024

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 11b5b0a12f415ad24250b2e3e8e0af74af9be33a

Compatibility test results for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 11b5b0a12f415ad24250b2e3e8e0af74af9be33a (PR)
1. Check liveness of validators at old version: 94976266c0e4edd1a31a3783be4c4184f8892ff5
compatibility::simple-validator-upgrade::liveness-check : committed: 14332.64 txn/s, latency: 2119.42 ms, (p50: 1800 ms, p70: 1900, p90: 2500 ms, p99: 8900 ms), latency samples: 553500
2. Upgrading first Validator to new version: 11b5b0a12f415ad24250b2e3e8e0af74af9be33a
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 8518.43 txn/s, latency: 3396.53 ms, (p50: 3800 ms, p70: 3900, p90: 4000 ms, p99: 4000 ms), latency samples: 155120
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7720.23 txn/s, latency: 4091.87 ms, (p50: 4000 ms, p70: 4000, p90: 6700 ms, p99: 7100 ms), latency samples: 255460
3. Upgrading rest of first batch to new version: 11b5b0a12f415ad24250b2e3e8e0af74af9be33a
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7212.10 txn/s, latency: 3935.24 ms, (p50: 4200 ms, p70: 4400, p90: 5100 ms, p99: 5200 ms), latency samples: 148060
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7598.83 txn/s, latency: 4230.65 ms, (p50: 4300 ms, p70: 4400, p90: 6400 ms, p99: 6700 ms), latency samples: 250280
4. upgrading second batch to new version: 11b5b0a12f415ad24250b2e3e8e0af74af9be33a
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11563.88 txn/s, latency: 2385.87 ms, (p50: 2500 ms, p70: 2700, p90: 3000 ms, p99: 3200 ms), latency samples: 200480
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10234.57 txn/s, latency: 3057.09 ms, (p50: 2700 ms, p70: 3100, p90: 6100 ms, p99: 7000 ms), latency samples: 329940
5. check swarm health
Compatibility test for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 11b5b0a12f415ad24250b2e3e8e0af74af9be33a passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant