Revert "[consensus] trigger sync based on remote LI timestamp"

[ibalajiarun]

This reverts commit af0b055.

[trunk-io]

⏱️ 37m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
rust-move-tests	12m	🟩
rust-doc-tests	5m	🟩
test-target-determinator	4m	🟩
execution-performance / test-target-determinator	4m	🟩
check	3m	🟩
check-dynamic-deps	2m	🟩 🟩
rust-cargo-deny	2m	🟩
fetch-last-released-docker-image-tag	2m	🟩
semgrep/ci	41s	🟩 🟩
general-lints	28s	🟩
file_change_determinator	21s	🟩 🟩
file_change_determinator	9s	🟩
execution-performance / single-node-performance	9s	🟩
permission-check	6s	🟩 🟩
permission-check	4s	🟩 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	9s	16m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite realistic_env_max_load success on 92b9bdbfb6b521a7a86d8ef3e83e4bb7e198af5b

two traffics test: inner traffic : committed: 14196.71 txn/s, latency: 2798.25 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5398000
two traffics test : committed: 99.96 txn/s, latency: 1796.61 ms, (p50: 1400 ms, p70: 1900, p90: 2100 ms, p99: 11000 ms), latency samples: 1880
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.271, avg: 1.355", "ConsensusProposalToOrdered: max: 0.311, avg: 0.291", "ConsensusOrderedToCommit: max: 0.378, avg: 0.368", "ConsensusProposalToCommit: max: 0.673, avg: 0.659"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.89s no progress at version 2128344 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.68s no progress at version 2128342 (avg 14.21s) [limit 16].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 327445f70a3b9474f13a792e8ada9b85809dec86 ==> 92b9bdbfb6b521a7a86d8ef3e83e4bb7e198af5b

Compatibility test results for 327445f70a3b9474f13a792e8ada9b85809dec86 ==> 92b9bdbfb6b521a7a86d8ef3e83e4bb7e198af5b (PR)
Upgrade the nodes to version: 92b9bdbfb6b521a7a86d8ef3e83e4bb7e198af5b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1250.27 txn/s, submitted: 1250.72 txn/s, failed submission: 0.45 txn/s, expired: 0.45 txn/s, latency: 2669.10 ms, (p50: 2100 ms, p70: 2700, p90: 4800 ms, p99: 6300 ms), latency samples: 111980
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1296.41 txn/s, submitted: 1299.97 txn/s, failed submission: 3.56 txn/s, expired: 3.56 txn/s, latency: 2329.31 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 5100 ms), latency samples: 116500
5. check swarm health
Compatibility test for 327445f70a3b9474f13a792e8ada9b85809dec86 ==> 92b9bdbfb6b521a7a86d8ef3e83e4bb7e198af5b passed
Upgrade the remaining nodes to version: 92b9bdbfb6b521a7a86d8ef3e83e4bb7e198af5b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1377.86 txn/s, submitted: 1379.99 txn/s, failed submission: 2.13 txn/s, expired: 2.13 txn/s, latency: 2404.14 ms, (p50: 2400 ms, p70: 2700, p90: 3300 ms, p99: 5100 ms), latency samples: 116220
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on 327445f70a3b9474f13a792e8ada9b85809dec86 ==> 92b9bdbfb6b521a7a86d8ef3e83e4bb7e198af5b

Compatibility test results for 327445f70a3b9474f13a792e8ada9b85809dec86 ==> 92b9bdbfb6b521a7a86d8ef3e83e4bb7e198af5b (PR)
1. Check liveness of validators at old version: 327445f70a3b9474f13a792e8ada9b85809dec86
compatibility::simple-validator-upgrade::liveness-check : committed: 15230.88 txn/s, latency: 2195.69 ms, (p50: 1900 ms, p70: 2100, p90: 3500 ms, p99: 5400 ms), latency samples: 499340
2. Upgrading first Validator to new version: 92b9bdbfb6b521a7a86d8ef3e83e4bb7e198af5b
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6699.79 txn/s, latency: 4183.45 ms, (p50: 4500 ms, p70: 4700, p90: 5700 ms, p99: 6000 ms), latency samples: 127160
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7085.77 txn/s, latency: 4562.16 ms, (p50: 4700 ms, p70: 5000, p90: 6500 ms, p99: 7100 ms), latency samples: 236500
3. Upgrading rest of first batch to new version: 92b9bdbfb6b521a7a86d8ef3e83e4bb7e198af5b
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7822.89 txn/s, latency: 3641.30 ms, (p50: 4000 ms, p70: 4300, p90: 4300 ms, p99: 4400 ms), latency samples: 143160
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7758.10 txn/s, latency: 4112.76 ms, (p50: 4400 ms, p70: 4500, p90: 5600 ms, p99: 6200 ms), latency samples: 258340
4. upgrading second batch to new version: 92b9bdbfb6b521a7a86d8ef3e83e4bb7e198af5b
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11775.83 txn/s, latency: 2350.38 ms, (p50: 2500 ms, p70: 2700, p90: 2900 ms, p99: 3000 ms), latency samples: 202140
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11523.66 txn/s, latency: 2730.32 ms, (p50: 2700 ms, p70: 2800, p90: 4200 ms, p99: 5200 ms), latency samples: 373600
5. check swarm health
Compatibility test for 327445f70a3b9474f13a792e8ada9b85809dec86 ==> 92b9bdbfb6b521a7a86d8ef3e83e4bb7e198af5b passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking