Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert back backpressure change until execution pool #15372

Merged

Conversation

igor-aptos
Copy link
Contributor

Reverts #15220 until execution pool is out.

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 22, 2024

@igor-aptos igor-aptos enabled auto-merge (rebase) November 22, 2024 21:21

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 327445f70a3b9474f13a792e8ada9b85809dec86 ==> 2619aedb53f1e0a25fd1236daa4b577982300f16

Compatibility test results for 327445f70a3b9474f13a792e8ada9b85809dec86 ==> 2619aedb53f1e0a25fd1236daa4b577982300f16 (PR)
1. Check liveness of validators at old version: 327445f70a3b9474f13a792e8ada9b85809dec86
compatibility::simple-validator-upgrade::liveness-check : committed: 16434.67 txn/s, latency: 2062.95 ms, (p50: 2100 ms, p70: 2100, p90: 2400 ms, p99: 2900 ms), latency samples: 535080
2. Upgrading first Validator to new version: 2619aedb53f1e0a25fd1236daa4b577982300f16
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7103.70 txn/s, latency: 3795.11 ms, (p50: 4200 ms, p70: 4400, p90: 4700 ms, p99: 5000 ms), latency samples: 146700
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7440.79 txn/s, latency: 4247.03 ms, (p50: 4300 ms, p70: 4500, p90: 6700 ms, p99: 7000 ms), latency samples: 249820
3. Upgrading rest of first batch to new version: 2619aedb53f1e0a25fd1236daa4b577982300f16
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6935.06 txn/s, latency: 4109.54 ms, (p50: 4600 ms, p70: 4900, p90: 5000 ms, p99: 5000 ms), latency samples: 129280
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7200.00 txn/s, latency: 4487.38 ms, (p50: 4900 ms, p70: 5000, p90: 5100 ms, p99: 5200 ms), latency samples: 237220
4. upgrading second batch to new version: 2619aedb53f1e0a25fd1236daa4b577982300f16
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11914.57 txn/s, latency: 2297.37 ms, (p50: 2500 ms, p70: 2600, p90: 2800 ms, p99: 2900 ms), latency samples: 207640
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11477.70 txn/s, latency: 2716.00 ms, (p50: 2600 ms, p70: 2700, p90: 4600 ms, p99: 5800 ms), latency samples: 370660
5. check swarm health
Compatibility test for 327445f70a3b9474f13a792e8ada9b85809dec86 ==> 2619aedb53f1e0a25fd1236daa4b577982300f16 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 2619aedb53f1e0a25fd1236daa4b577982300f16

two traffics test: inner traffic : committed: 14322.51 txn/s, latency: 2821.99 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 12600 ms), latency samples: 5446040
two traffics test : committed: 100.06 txn/s, latency: 1567.11 ms, (p50: 1400 ms, p70: 1500, p90: 1500 ms, p99: 5900 ms), latency samples: 1700
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.013, avg: 1.549", "ConsensusProposalToOrdered: max: 0.308, avg: 0.291", "ConsensusOrderedToCommit: max: 0.375, avg: 0.369", "ConsensusProposalToCommit: max: 0.665, avg: 0.659"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.10s no progress at version 1501768 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.49s no progress at version 5875013 (avg 8.44s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 327445f70a3b9474f13a792e8ada9b85809dec86 ==> 2619aedb53f1e0a25fd1236daa4b577982300f16

Compatibility test results for 327445f70a3b9474f13a792e8ada9b85809dec86 ==> 2619aedb53f1e0a25fd1236daa4b577982300f16 (PR)
Upgrade the nodes to version: 2619aedb53f1e0a25fd1236daa4b577982300f16
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1380.48 txn/s, submitted: 1382.64 txn/s, failed submission: 2.17 txn/s, expired: 2.17 txn/s, latency: 2362.69 ms, (p50: 2100 ms, p70: 2400, p90: 3900 ms, p99: 5000 ms), latency samples: 114660
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1306.53 txn/s, submitted: 1309.61 txn/s, failed submission: 3.07 txn/s, expired: 3.07 txn/s, latency: 2369.41 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 5400 ms), latency samples: 119000
5. check swarm health
Compatibility test for 327445f70a3b9474f13a792e8ada9b85809dec86 ==> 2619aedb53f1e0a25fd1236daa4b577982300f16 passed
Upgrade the remaining nodes to version: 2619aedb53f1e0a25fd1236daa4b577982300f16
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1265.07 txn/s, submitted: 1267.70 txn/s, failed submission: 2.63 txn/s, expired: 2.63 txn/s, latency: 2589.02 ms, (p50: 2000 ms, p70: 2700, p90: 5400 ms, p99: 6900 ms), latency samples: 115500
Test Ok

@igor-aptos igor-aptos merged commit 7a99d37 into main Nov 22, 2024
133 of 143 checks passed
@igor-aptos igor-aptos deleted the igor/change_back_backpressure_before_execution_pool branch November 22, 2024 21:50
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
aptos-release-v1.24

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants