[cp 1.23] Move payload_manager.notify_commit() to after commit

[msmouse]

this is to cherry-pick #15361 to v1.23

[trunk-io]

⏱️ 4h 5m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	54m	🟩 🟩
rust-unit-tests	43m	🟥 🟩
rust-unit-tests	42m	🟥 🟩
rust-unit-tests	19m	⬜
execution-performance / test-target-determinator	11m	🟩 🟩
test-target-determinator	10m	🟩 🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
check	7m	🟩 🟩
rust-cargo-deny	7m	⬜ 🟩 🟩 🟩
check-dynamic-deps	5m	🟩 🟩 🟩 🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
fetch-last-released-docker-image-tag	3m	🟩 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	27m	16m
execution-performance / test-target-determinator	6m	4m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[trunk-io]

     

View Full Report ↗︎ ⋅ Docs

[github-actions]

✅ Forge suite realistic_env_max_load success on 419d75130bd385cda0e950bcd2547f947a489ef4

two traffics test: inner traffic : committed: 14273.61 txn/s, latency: 2783.35 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5427160
two traffics test : committed: 99.95 txn/s, latency: 1474.23 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 6100 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.019, avg: 1.593", "ConsensusProposalToOrdered: max: 0.316, avg: 0.295", "ConsensusOrderedToCommit: max: 0.391, avg: 0.370", "ConsensusProposalToCommit: max: 0.690, avg: 0.665"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.17s no progress at version 2076115 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.50s no progress at version 2076113 (avg 7.33s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4

Compatibility test results for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4 (PR)
Upgrade the nodes to version: 419d75130bd385cda0e950bcd2547f947a489ef4
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1361.19 txn/s, submitted: 1361.97 txn/s, failed submission: 0.78 txn/s, expired: 0.78 txn/s, latency: 2715.55 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 5200 ms), latency samples: 105320
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1305.19 txn/s, submitted: 1307.44 txn/s, failed submission: 2.25 txn/s, expired: 2.25 txn/s, latency: 2319.65 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 5300 ms), latency samples: 115880
5. check swarm health
Compatibility test for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4 passed
Upgrade the remaining nodes to version: 419d75130bd385cda0e950bcd2547f947a489ef4
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1298.46 txn/s, submitted: 1301.85 txn/s, failed submission: 3.38 txn/s, expired: 3.38 txn/s, latency: 2318.91 ms, (p50: 2100 ms, p70: 2400, p90: 3900 ms, p99: 5500 ms), latency samples: 115080
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4

Compatibility test results for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4 (PR)
1. Check liveness of validators at old version: afa8d75c467820b7d96bbe13ab0d011c12f8b3a3
compatibility::simple-validator-upgrade::liveness-check : committed: 14384.39 txn/s, latency: 2370.74 ms, (p50: 1900 ms, p70: 2100, p90: 3300 ms, p99: 9600 ms), latency samples: 497340
2. Upgrading first Validator to new version: 419d75130bd385cda0e950bcd2547f947a489ef4
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7380.36 txn/s, latency: 3740.34 ms, (p50: 4100 ms, p70: 4400, p90: 4600 ms, p99: 4700 ms), latency samples: 135320
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7190.69 txn/s, latency: 4464.15 ms, (p50: 4700 ms, p70: 4900, p90: 6100 ms, p99: 6400 ms), latency samples: 243340
3. Upgrading rest of first batch to new version: 419d75130bd385cda0e950bcd2547f947a489ef4
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7888.14 txn/s, latency: 3637.33 ms, (p50: 4100 ms, p70: 4300, p90: 4400 ms, p99: 4400 ms), latency samples: 146360
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2925.82 txn/s, submitted: 2925.95 txn/s, expired: 0.13 txn/s, latency: 4133.22 ms, (p50: 4500 ms, p70: 4600, p90: 4800 ms, p99: 5100 ms), latency samples: 256589
4. upgrading second batch to new version: 419d75130bd385cda0e950bcd2547f947a489ef4
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12015.49 txn/s, latency: 2330.77 ms, (p50: 2500 ms, p70: 2600, p90: 2900 ms, p99: 3100 ms), latency samples: 205480
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10184.30 txn/s, latency: 3042.76 ms, (p50: 2600 ms, p70: 3000, p90: 6100 ms, p99: 7800 ms), latency samples: 331080
5. check swarm health
Compatibility test for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> 419d75130bd385cda0e950bcd2547f947a489ef4 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking