Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manu/FA coinstore loc for sharded #15349

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

manudhundi
Copy link
Contributor

  • [FA] get rid of migration flag
  • If FA is enabled, pass correct coin_store_location in read/write sets of sharded txns

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 21, 2024

⏱️ 11m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 7m 🟥
rust-cargo-deny 2m 🟩
check-dynamic-deps 41s 🟩
semgrep/ci 30s 🟩
general-lints 27s 🟩
file_change_determinator 13s 🟩
permission-check 7s 🟩🟩
permission-check 6s 🟩🟩
check-branch-prefix 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@manudhundi manudhundi changed the base branch from main to lightmark/deprecate_migration_flag November 21, 2024 04:00
@manudhundi manudhundi marked this pull request as ready for review November 21, 2024 04:00
@lightmark
Copy link
Contributor

could you rebase on lightmark/deprecate_migration_flag and test all the tests pass still?

@manudhundi manudhundi mentioned this pull request Nov 21, 2024
22 tasks
@lightmark lightmark force-pushed the lightmark/deprecate_migration_flag branch 3 times, most recently from 31c576a to f983046 Compare November 22, 2024 02:27
@manudhundi manudhundi force-pushed the manu/FA_coinstore_loc_for_sharded branch from a4c1b24 to 0a45e67 Compare November 22, 2024 02:47
@manudhundi manudhundi changed the base branch from lightmark/deprecate_migration_flag to main November 22, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants