use gce runner for execution-performance benchmark #15300
+146
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 57m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
aluon
force-pushed
the
aluon/push-qxuywlyknkwr
branch
from
27d066a
to
0c14aab
Compare
aluon
added
the
CICD:run-execution-performance-test
aluon
force-pushed
the
aluon/push-qxuywlyknkwr
branch
from
0c14aab
to
3553bbc
Compare
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ inputs.GIT_SHA }} | ||
| if: ${{ inputs.IGNORE_TARGET_DETERMINATION || needs.test-target-determinator.outputs.run_execution_performance_test == 'true' }} | ||
|
|
||
| - uses: aptos-labs/aptos-core/.github/actions/rust-setup@main | ||
| - uses: aptos-labs/aptos-core./.github/actions/rust-setup@main |
There was a problem hiding this comment.
There appears to be an extra period in the action path aptos-labs/aptos-core./.github/actions/rust-setup@main which will cause the action to fail. The correct path should be aptos-labs/aptos-core/.github/actions/rust-setup@main.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate the execution-performance workflow to using CE instances instead of using runners from our CI cluster
I'm using the related-sciences/gce-github-runner action to create and cleanup the instance. I forked this with some changes to make it work with our dev_setup.sh
How Has This Been Tested?
https://github.com/aptos-labs/aptos-core/actions/runs/11898685620/job/33396239201?pr=15300
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist