Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Enable V2 loader #15155

Merged
merged 9 commits into from
Nov 14, 2024
Merged

[move] Enable V2 loader #15155

merged 9 commits into from
Nov 14, 2024

Conversation

georgemitenkov
Copy link
Contributor

@georgemitenkov georgemitenkov commented Nov 1, 2024

Description

This PR enables loader V2 as default implementation. It is used as the base PR for any loader V2 work so that we can track performance, fixes with the flag on.

The stack of PRs on top that have to be approved first:

Good to land soon:

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@georgemitenkov georgemitenkov marked this pull request as ready for review November 1, 2024 18:55
Copy link
Contributor Author

georgemitenkov commented Nov 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @georgemitenkov and the rest of your teammates on Graphite Graphite

@georgemitenkov georgemitenkov changed the title [move] Enable V2 loader [DO NOT LAND] Enable V2 loader Nov 1, 2024
@georgemitenkov georgemitenkov added CICD:run-execution-performance-test Run execution performance test CICD:run-execution-performance-full-test Run execution performance test (full version) labels Nov 2, 2024
@georgemitenkov georgemitenkov removed CICD:run-execution-performance-test Run execution performance test CICD:run-execution-performance-full-test Run execution performance test (full version) labels Nov 2, 2024
@georgemitenkov georgemitenkov requested a review from a team as a code owner November 4, 2024 13:52
@georgemitenkov georgemitenkov removed the request for review from a team November 4, 2024 13:57
@georgemitenkov georgemitenkov force-pushed the george/enable-loader-v2 branch 2 times, most recently from ce1a08b to e5e1b28 Compare November 12, 2024 08:29

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 0f648ae553bf894c371f1947ec0f07bfe9b7ecbd

two traffics test: inner traffic : committed: 14455.62 txn/s, latency: 2752.00 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3000 ms), latency samples: 5496420
two traffics test : committed: 99.95 txn/s, latency: 1561.56 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 10000 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.021, avg: 1.565", "ConsensusProposalToOrdered: max: 0.316, avg: 0.292", "ConsensusOrderedToCommit: max: 0.373, avg: 0.363", "ConsensusProposalToCommit: max: 0.664, avg: 0.655"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.81s no progress at version 2187057 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.60s no progress at version 2187055 (avg 8.60s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on a0ec6ba11bfe4cfc5b586edc9e227aba4909e8fe ==> 0f648ae553bf894c371f1947ec0f07bfe9b7ecbd

Compatibility test results for a0ec6ba11bfe4cfc5b586edc9e227aba4909e8fe ==> 0f648ae553bf894c371f1947ec0f07bfe9b7ecbd (PR)
Upgrade the nodes to version: 0f648ae553bf894c371f1947ec0f07bfe9b7ecbd
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1478.08 txn/s, submitted: 1480.17 txn/s, failed submission: 2.09 txn/s, expired: 2.09 txn/s, latency: 2252.97 ms, (p50: 2100 ms, p70: 2200, p90: 3700 ms, p99: 5100 ms), latency samples: 127440
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1477.83 txn/s, submitted: 1481.40 txn/s, failed submission: 3.58 txn/s, expired: 3.58 txn/s, latency: 2072.17 ms, (p50: 1900 ms, p70: 2100, p90: 3000 ms, p99: 4200 ms), latency samples: 132200
5. check swarm health
Compatibility test for a0ec6ba11bfe4cfc5b586edc9e227aba4909e8fe ==> 0f648ae553bf894c371f1947ec0f07bfe9b7ecbd passed
Upgrade the remaining nodes to version: 0f648ae553bf894c371f1947ec0f07bfe9b7ecbd
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1421.46 txn/s, submitted: 1425.17 txn/s, failed submission: 3.71 txn/s, expired: 3.71 txn/s, latency: 2118.70 ms, (p50: 2100 ms, p70: 2100, p90: 3000 ms, p99: 4200 ms), latency samples: 130180
Test Ok

Copy link
Contributor

✅ Forge suite compat success on a0ec6ba11bfe4cfc5b586edc9e227aba4909e8fe ==> 0f648ae553bf894c371f1947ec0f07bfe9b7ecbd

Compatibility test results for a0ec6ba11bfe4cfc5b586edc9e227aba4909e8fe ==> 0f648ae553bf894c371f1947ec0f07bfe9b7ecbd (PR)
1. Check liveness of validators at old version: a0ec6ba11bfe4cfc5b586edc9e227aba4909e8fe
compatibility::simple-validator-upgrade::liveness-check : committed: 18482.05 txn/s, latency: 1846.96 ms, (p50: 1800 ms, p70: 2000, p90: 2100 ms, p99: 2200 ms), latency samples: 593980
2. Upgrading first Validator to new version: 0f648ae553bf894c371f1947ec0f07bfe9b7ecbd
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 8045.42 txn/s, latency: 3512.40 ms, (p50: 3900 ms, p70: 4200, p90: 4200 ms, p99: 4300 ms), latency samples: 145140
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7218.03 txn/s, latency: 4366.29 ms, (p50: 4300 ms, p70: 4300, p90: 6700 ms, p99: 7200 ms), latency samples: 242920
3. Upgrading rest of first batch to new version: 0f648ae553bf894c371f1947ec0f07bfe9b7ecbd
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7199.36 txn/s, latency: 3768.75 ms, (p50: 4000 ms, p70: 4300, p90: 5300 ms, p99: 5400 ms), latency samples: 131120
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7917.67 txn/s, latency: 4069.62 ms, (p50: 4200 ms, p70: 4300, p90: 6200 ms, p99: 6300 ms), latency samples: 259420
4. upgrading second batch to new version: 0f648ae553bf894c371f1947ec0f07bfe9b7ecbd
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11147.16 txn/s, latency: 2271.81 ms, (p50: 2200 ms, p70: 2600, p90: 2900 ms, p99: 4200 ms), latency samples: 222320
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11472.98 txn/s, latency: 2722.36 ms, (p50: 2200 ms, p70: 2700, p90: 5400 ms, p99: 7400 ms), latency samples: 370640
5. check swarm health
Compatibility test for a0ec6ba11bfe4cfc5b586edc9e227aba4909e8fe ==> 0f648ae553bf894c371f1947ec0f07bfe9b7ecbd passed
Test Ok

@georgemitenkov georgemitenkov merged commit ba4c827 into main Nov 14, 2024
52 checks passed
@georgemitenkov georgemitenkov deleted the george/enable-loader-v2 branch November 14, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants