Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webauthn] Remove passkey comment references to passkeys-ts #14071

Closed
wants to merge 1 commit into from

Conversation

hariria
Copy link
Contributor

@hariria hariria commented Jul 21, 2024

Description

The passkeys-ts repo was created temporarily as an internal repo for client testing of the passkey authenticator. Development moved from there to aptos-labs/aptos-ts-sdk#194 and thus references to passkeys-ts can be removed.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@hariria hariria self-assigned this Jul 21, 2024
Copy link

trunk-io bot commented Jul 21, 2024

⏱️ 21m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 15m 🟩
rust-cargo-deny 2m 🟩
general-lints 2m 🟩
check-dynamic-deps 1m 🟩
semgrep/ci 21s 🟩
file_change_determinator 12s 🟩
file_change_determinator 11s 🟩
permission-check 7s 🟩
permission-check 4s 🟩
permission-check 4s 🟩
permission-check 2s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

github-actions bot commented Sep 5, 2024

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Sep 5, 2024
@github-actions github-actions bot closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant