-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix gas for comparison testing tool #13335
base: main
Are you sure you want to change the base?
Conversation
⏱️ 4h 37m total CI duration on this PR
🚨 2 jobs on the last run were significantly faster/slower than expected
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13335 +/- ##
=======================================
Coverage 60.1% 60.1%
=======================================
Files 856 856
Lines 211110 211139 +29
=======================================
+ Hits 126962 126998 +36
+ Misses 84148 84141 -7 ☔ View full report in Codecov by Sentry. |
3470545
to
235bf24
Compare
91ee13b
to
a18a5d3
Compare
daa899c
to
2f9f5c2
Compare
2f9f5c2
to
ca0d274
Compare
8d829ed
to
c178c65
Compare
0d7ef7c
to
1bde51e
Compare
ace43e6
to
d198a70
Compare
e24e4f9
to
42f0192
Compare
2575a31
to
ff565d4
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @rahxephon89 and the rest of your teammates on Graphite |
ff565d4
to
9188227
Compare
7c723de
to
cf21c46
Compare
93cc380
to
201e3ac
Compare
201e3ac
to
f0c8c7c
Compare
ce398ca
to
b3d34d2
Compare
b3d34d2
to
5c6ad61
Compare
5c6ad61
to
f278efe
Compare
@@ -684,6 +684,10 @@ impl SignedTransaction { | |||
self.raw_txn.max_gas_amount | |||
} | |||
|
|||
pub fn set_max_gmount(&mut self, new_value: u64) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method name set_max_gmount
appears to contain a typo - it should be set_max_gas_amount
to match the naming pattern established by the corresponding getter method max_gas_amount()
. This maintains consistency in the API and improves code readability.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Description
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist