Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix gas for comparison testing tool #13335

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Conversation

rahxephon89
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented May 18, 2024

⏱️ 4h 37m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-targeted-unit-tests 1h 30m 🟥🟥🟥🟩
rust-move-unit-coverage 1h 2m 🟩🟩🟩🟩
rust-move-tests 1h 2m 🟩🟩🟩🟩🟩
rust-lints 23m 🟩🟩🟩🟩
run-tests-main-branch 18m 🟩🟩🟩🟩
general-lints 7m 🟩🟩🟩🟩
file_change_determinator 6m 🟩🟩🟩🟩
check-dynamic-deps 5m 🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
file_change_determinator 38s 🟩🟩🟩🟩
permission-check 34s 🟩🟩🟩🟩
permission-check 17s 🟩🟩🟩🟩
permission-check 12s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-move-tests 15m 9m +79%
rust-targeted-unit-tests 23m 18m +32%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 41.37931% with 17 lines in your changes missing coverage. Please review.

Project coverage is 60.1%. Comparing base (0e4f5df) to head (f64d7b4).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
aptos-move/aptos-vm-types/src/environment.rs 0.0% 9 Missing ⚠️
third_party/move/move-compiler-v2/src/options.rs 68.7% 5 Missing ⚠️
types/src/transaction/mod.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13335   +/-   ##
=======================================
  Coverage    60.1%    60.1%           
=======================================
  Files         856      856           
  Lines      211110   211139   +29     
=======================================
+ Hits       126962   126998   +36     
+ Misses      84148    84141    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahxephon89 rahxephon89 force-pushed the teng/fix-gas branch 4 times, most recently from 3470545 to 235bf24 Compare May 26, 2024 04:22
@rahxephon89 rahxephon89 force-pushed the teng/fix-gas branch 2 times, most recently from 91ee13b to a18a5d3 Compare June 2, 2024 03:29
@rahxephon89 rahxephon89 force-pushed the teng/fix-gas branch 4 times, most recently from daa899c to 2f9f5c2 Compare June 21, 2024 21:51
@rahxephon89 rahxephon89 force-pushed the teng/fix-gas branch 5 times, most recently from 8d829ed to c178c65 Compare July 19, 2024 21:53
@rahxephon89 rahxephon89 force-pushed the teng/fix-gas branch 2 times, most recently from 0d7ef7c to 1bde51e Compare July 23, 2024 05:47
@rahxephon89 rahxephon89 force-pushed the teng/fix-gas branch 3 times, most recently from ace43e6 to d198a70 Compare August 6, 2024 02:21
@rahxephon89 rahxephon89 force-pushed the teng/fix-gas branch 2 times, most recently from e24e4f9 to 42f0192 Compare August 18, 2024 21:52
@rahxephon89 rahxephon89 force-pushed the teng/fix-gas branch 3 times, most recently from 2575a31 to ff565d4 Compare August 27, 2024 06:57
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rahxephon89 and the rest of your teammates on Graphite Graphite

@@ -684,6 +684,10 @@ impl SignedTransaction {
self.raw_txn.max_gas_amount
}

pub fn set_max_gmount(&mut self, new_value: u64) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method name set_max_gmount appears to contain a typo - it should be set_max_gas_amount to match the naming pattern established by the corresponding getter method max_gas_amount(). This maintains consistency in the API and improves code readability.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant