Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/debianization #1393

Merged
merged 5 commits into from
Nov 17, 2024
Merged

Improve/debianization #1393

merged 5 commits into from
Nov 17, 2024

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Nov 15, 2024

Description of the Change

Synchronize with official debian packaging.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.84%. Comparing base (31ccce1) to head (14e4f3d).
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1393   +/-   ##
=======================================
  Coverage   74.84%   74.84%           
=======================================
  Files         157      157           
  Lines       18101    18101           
=======================================
  Hits        13548    13548           
  Misses       3453     3453           
  Partials     1100     1100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx force-pushed the improve/debianization branch 7 times, most recently from ca2fb49 to ab7638d Compare November 16, 2024 11:55
@neolynx neolynx self-assigned this Nov 16, 2024
@neolynx neolynx added the needs review Ready for review & merge label Nov 16, 2024
@neolynx neolynx requested a review from a team November 16, 2024 13:15
@neolynx neolynx force-pushed the improve/debianization branch 6 times, most recently from d748c27 to 9c2e95d Compare November 16, 2024 17:55
@iofq
Copy link
Contributor

iofq commented Nov 16, 2024

Looks like the debug symbol file is potentially not working:

From CI build logs:

 dh_strip --dbg-package=aptly-dbg
dh_strip: warning: Could not find the BuildID in debian/aptly/usr/bin/aptly
readelf: Error: Unable to find program interpreter name
dh_strip: warning: Could not find the BuildID in debian/aptly-dbg/usr/lib/debug/usr/bin/aptly
omitted......
E: aptly-dbg: stripped-library [usr/lib/debug/usr/bin/aptly]
W: aptly-dbg: debug-file-with-no-debug-symbols [usr/lib/debug/usr/bin/aptly]

@neolynx
Copy link
Member Author

neolynx commented Nov 17, 2024

Looks like the debug symbol file is potentially not working:

I think this is just a warning, and probably due to not building with debian dependencies. the aptly binary is stripped in the package, otherwise lintian would complain about this...

@neolynx neolynx force-pushed the improve/debianization branch 5 times, most recently from 628059d to b47bd35 Compare November 17, 2024 14:40
@neolynx neolynx merged commit d96ef0f into master Nov 17, 2024
46 checks passed
@neolynx neolynx deleted the improve/debianization branch November 17, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs approval needs review Ready for review & merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants