Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Replace all references to debian 8 with 11 #1215

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

reglim
Copy link
Contributor

@reglim reglim commented Sep 13, 2023

Fixes #1218

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Updated the repo key, repo links in tests (jessie-cran35 -> bullseye-cran40) and the expected test output.

Why this change is important?

The CI should pass

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@reglim reglim force-pushed the fix/pipeline-failing-r-project-outdated-mirror branch 17 times, most recently from 51d9893 to 903d0a7 Compare September 14, 2023 07:59
Updated the repo key, repo links in tests (jessie-cran35 -> bullseye-cran40) and the expected test output.

Fixes: #1218
@reglim reglim force-pushed the fix/pipeline-failing-r-project-outdated-mirror branch from 903d0a7 to 3ae5144 Compare September 14, 2023 08:19
@reglim reglim changed the title Draft: Fix: Replace all references to debian 8 with 11 Fix: Replace all references to debian 8 with 11 Sep 14, 2023
@aptly-dev aptly-dev deleted a comment from codecov bot Sep 14, 2023
Copy link
Contributor

@randombenj randombenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #1215 (3ae5144) into master (1df8cff) will decrease coverage by 0.04%.
Report is 6 commits behind head on master.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master    #1215      +/-   ##
==========================================
- Coverage   65.99%   65.96%   -0.04%     
==========================================
  Files         143      143              
  Lines       16196    16190       -6     
==========================================
- Hits        10688    10679       -9     
- Misses       4754     4758       +4     
+ Partials      754      753       -1     
Files Changed Coverage Δ
api/mirror.go 14.78% <0.00%> (ø)
deb/graph.go 0.00% <0.00%> (ø)
api/task.go 42.15% <100.00%> (ø)
deb/import.go 76.50% <100.00%> (+0.92%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@reglim reglim merged commit 18203c6 into master Sep 14, 2023
6 of 7 checks passed
@reglim reglim deleted the fix/pipeline-failing-r-project-outdated-mirror branch September 14, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Pipeline failing because of change in R-Project Repo
2 participants