Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new session id #10

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Use new session id #10

merged 4 commits into from
Nov 10, 2023

Conversation

goenning
Copy link
Member

This PR:

  • Automatically generates session id based on the new version
  • Ignores any calls to SessionId as they are no longer needed
  • Removes automatic SessionStart and SessionEnd events to make it behave like other SDKs
  • Updates the package version

@goenning
Copy link
Member Author

I've never run this code so I don't know if it works, the session id generation was written by ChatGPT :)
I'll try run this later today, but I just thought that maybe you could eye ball the PR to see if anythings stands out for you @pasotee ?

@goenning goenning merged commit a89c424 into main Nov 10, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@goenning