Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix categorical nans #317

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Fix categorical nans #317

merged 3 commits into from
Nov 11, 2024

Conversation

loreloc
Copy link
Member

@loreloc loreloc commented Nov 11, 2024

  • Removed unnecessary transpositions in the Categorical index-based implementation
  • Replaced Categorical one-hot implementation with the index-based as it is generally faster and more memory efficient anyway

Closes #311 .

@loreloc loreloc added bug Something isn't working enhancement New feature or request labels Nov 11, 2024
@loreloc loreloc self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.18%. Comparing base (4bb4617) to head (669958c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cirkit/backend/torch/layers/input.py 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   68.18%   68.18%           
=======================================
  Files          51       51           
  Lines        5366     5366           
  Branches      615      615           
=======================================
  Hits         3659     3659           
  Misses       1491     1491           
  Partials      216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loreloc loreloc merged commit 3ce47e0 into main Nov 11, 2024
2 of 4 checks passed
@loreloc loreloc deleted the fix-categorical-nans-311 branch November 11, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categorical layer outputs NaN when probabilities are 0 (-inf in log domain)
1 participant