Reinstate the back button on tutorials #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
reviewed
Oct 31, 2024
src/lib/layouts/DocsTutorial.svelte
Outdated
Comment on lines
60
to
62
| class=" | ||
| web-button is-text is-only-icon web-u-cross-center web-u-size-40 | ||
| u-position-absolute u-inset-inline-start-0 -translate-x-1/2" |
There was a problem hiding this comment.
Is all this extra spacing intended?
There was a problem hiding this comment.
I've reverted it from how it was before. I only switch the 100% negative translateX (from pink v1 class) to the Tailwind -translate-x-1/2 so it visually looks as in the design.
There was a problem hiding this comment.
I meant the indentation in the code itself:
class="
web-button is-text is-only-icon web-u-cross-center
web-is-not-mobile -translate-x-1/2"
instead of something like:
class="web-button is-text is-only-icon web-u-cross-center
web-is-not-mobile -translate-x-1/2"
stnguyen90
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Brings back the back button on tutorial pages that have it in the markdoc:
Have you read the Contributing Guidelines on issues?
✅