Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Documentation queries mismatch #1362

Closed
wants to merge 2 commits into from

Conversation

askadityapandey
Copy link

What does this PR do?

fixes #1353 ,

Test Plan

It's a very minor change, easily visible.

Have you read the Contributing Guidelines on issues?

Yes.

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@askadityapandey, if you're interested in working on an issue, please comment on the issue and asked to be assigned.

Also, the issue was to review all the queries and not just the examples mentioned in the issue.

@askadityapandey
Copy link
Author

@askadityapandey, if you're interested in working on an issue, please comment on the issue and asked to be assigned.

Also, the issue was to review all the queries and not just the examples mentioned in the issue.

Hey @stnguyen90 , thanks for your clarification. I'll take care of asking first from the next time.
Also do you have any suggestion or Idea how can I quickly check all the queries? I mean I am manually checking right now and I haven't found Query.greaterThanEqual in Node.Js while it's in Documentation.

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also do you have any suggestion or Idea how can I quickly check all the queries? I mean I am manually checking right now and I haven't found Query.greaterThanEqual in Node.Js while it's in Documentation.

@askadityapandey you can install the SDK and test it out in an IDE. Or you can look at the source code. For example, https://github.com/appwrite/sdk-for-node/blob/7a2418cafaf3cff4247b2e8d9c106e1ab7e9288b/src/query.ts#L108.

@stnguyen90
Copy link
Contributor

Closing insufficient and stale PR

@stnguyen90 stnguyen90 closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📚 Documentation: Double check queries
2 participants