-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit Tests - Android + Kotlin #729
base: master
Are you sure you want to change the base?
Conversation
17e9c9e
to
2ddb9cf
Compare
50b8538
to
cb11459
Compare
cb11459
to
4d99588
Compare
Awesome PR 😃 |
4d99588
to
1108db7
Compare
Converting this to a draft for the time being until I figure out what gradle version still works with Java 8 to get the pipeline green. Not sure when I will get to it since I am uncertain how long setting up the build locally for proper testing will take. |
6cb9312
to
f8d4e7d
Compare
After lots of battling, I found 2 culprits that were causing issues with tests:
I have no idea why node is failing now; this is cruel but I am relatively confident that's not my fault because I didn't touch node. |
This is fixed on the 1.5.x branch now, you may rebase to this if you want to see everything pass |
Ah, I see! I will hold off on that I until that's merged I think to avoid more chaos than necessary. As long as I know it was not my fault indeed and it's fixed somewhere else I got peace of mind! Thanks :) |
What does this PR do?
This PR adds generated unit tests to Android and Kotlin SDKs. It also contains some refactoring to generate similar classes from the same template to both the Android and Kotlin SDK, similar to how Dart and Flutter share templates.
Test Plan
I set up the generated project locally and ran the respective test command (
./gradlew library:test
for the Android SDK (requires Java 8-11 not higher!) and./gradlew test
for the Kotlin SDK)Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yup
Discord username for swag as requested by Tessa: yestheory