Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issues #36

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

sparebytes
Copy link

  • Enable strict null checks
  • Add declaration files to source and npm package
  • Ignore source *.d.ts files in npm package

@andreas-aeschlimann
Copy link
Member

Thanks for the great input!

Some of your commits were also suggested by the other pull requests, so I have integrated that already.

I am still thinking about the reflection integration. I have seen the approach when I created the package in the first place, but I decided not to go with any dependencies. On the other hand, it would be indeed much cleaner to use the reflection methods.

@sparebytes
Copy link
Author

I understand not wanting to add reflect-metadata as a dependency. I had run-time issues with the version I used because it clashed with Angular 2's version and presumably overwrote global variables that were already in use.

@andreas-aeschlimann
Copy link
Member

One of the great benefits for the real-world-use is for sure that you do not have to write "=undefined" for each property. And of course, with reflect-metadata the code of json2typescript gets cleaner itself.

@jmesa-sistel
Copy link

@andreas-aeschlimann
Do you plan to integrate reflect-metadata in the future?
It will be great not have to use undefined for each property.
Why not just use an internal copy as the PR is doing? You will have the control over the external dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants