Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 Merge #95

Merged
merged 14 commits into from
Nov 27, 2024
Merged

V2 Merge #95

merged 14 commits into from
Nov 27, 2024

Conversation

m13t
Copy link
Contributor

@m13t m13t commented Nov 27, 2024

No description provided.

@gambol99 @m13t
feat: separating out the codebase into individual modules
65950c5
@gambol99 @m13t
chore: adding the updated makefile
285b3a1
@gambol99 @m13t
fix: switching to using the local.account_id
15b5edd
@gambol99 @m13t
fix: using the bucket arn, not the name for the replication
b300569
@gambol99 @m13t
chore: adding the changes
f5c8ca1
@gambol99 @m13t
chore: fixing up the module
edb9b05
@gambol99 @m13t
docs: updating the docs to reflect the changes
b516808
@gambol99 @m13t
chore: working on the module transition
14ac73e
@gambol99 @m13t
feat/v2 (#92)
aa44f70 
* feat: adding back the cora export to the data account, as this is required and providing a toggle the data read permissions

* chore: removing the read permission variable and using the lack of organizational id
@gambol99 @m13t
feat: adding back the cora export to the data account, as this is req…
a8f14f6 
…uired and providing a toggle the data read permissions
@gambol99 @m13t
chore: removing the read permission variable and using the lack of or…
5050b00 
…ganizational id
@gambol99 @m13t
fix: messed up on the organizational id variable
9d60d1d
@gambol99 @m13t
fix: moving the files to the correct place
297a6d8
@gambol99 @m13t
fix: ensuring the dependency of the bucket
8c9451b
@github-actions GitHub Actions
Copy link

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 👮 Terraform Security Check: success
  • 🔘 Terraform Tests: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 🤖 Terraform Example Validation: success
  • 📖 Terraform Documentation: success
  • 🔖 Commitlint: failure

Working Directory: examples/basic
Pusher: @m13t, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-aws-cudos/actions/runs/12052401513

@gambol99 gambol99 merged commit a4e1d36 into main Nov 27, 2024
10 of 11 checks passed
@gambol99 gambol99 deleted the v2-lewis branch November 27, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gambol99 gambol99 gambol99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m13t @gambol99