Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs side menu hiding under the navbar #581

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sdrejkarz
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Side mine is no longer hiding on scrolling down on footer
Issue

Copy link
Contributor

@mkleszcz mkleszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this fix doesn't work as expected, introducing another bug:
It cuts the menu at the bottom and does not allow to scroll and see all menu items

image

@sdrejkarz
Copy link
Contributor Author

sdrejkarz commented Jun 3, 2024

The only easy-to-go solution I can see here is

aside > div:first-child  {
    height: unset;
    overflow-y: auto;
    overflow-x: hidden;
}

but having two scrollbars (body + sidebar) is not something that we would like to have (or maybe I'm wrong).

Edit: this doesn't work properly either when the scroll is visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants