deps: Update eslint to 9.3.0 #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emil-litwiniec
commented
May 27, 2024
| "command": "docker-compose run --rm --no-deps --entrypoint /bin/bash workers /app/packages/workers/scripts/runtime/run_lint.sh" | ||
| "commands": [ | ||
| "docker-compose run --rm --no-deps --entrypoint /bin/bash workers /app/packages/workers/scripts/runtime/run_lint.sh", | ||
| "pnpm nx run workers:lint:js" |
There was a problem hiding this comment.
@mkleszcz Let me know what do you think about this change, please. For some reason eslint config couldn't resolve the path to root config that is extended when run from the bash script.
emil-litwiniec
commented
May 27, 2024
| @@ -39,29 +41,29 @@ | |||
| "@types/jest": "^29.5.12", | |||
| "@types/node": "20.12.12", | |||
| "@types/ramda": "^0.28.25", | |||
| "@types/react": "^18.3.1", | |||
| "@types/react": "^18.3.3", | |||
There was a problem hiding this comment.
There is some weird dep that breaks the react types, which makes docs fail to build from time to time when new pnpm lock is being created. I need to investigate it and pin naughty package to a specific version.
mkleszcz
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Update eslint to new major version 9. It requires to use a new flat config, meaning all previous
.eslintrcoreslintrc.jsonfiles needed te be changed. Since some plugins are not 100% compatible with new version - compatibility utils from eslint were used.Additional changes worth mentioning:
webapprelated configs to extendwebapp-coreinstead of duplicating whole config fileeslintset unused disable rule as default, that revealed various places where line disables were obsolete - they were removed