Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update nx to 19.0.1 #546

Merged
merged 6 commits into from
May 13, 2024
Merged

deps: Update nx to 19.0.1 #546

merged 6 commits into from
May 13, 2024

Conversation

emil-litwiniec
Copy link
Contributor

@emil-litwiniec emil-litwiniec commented May 10, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Update nx to 19.0.1. Fix problems around types resolution in spec files in webapp-core package. That led to config update and removal of redundant React imports inside tests. Also @testing-library renderHook imports have been fixed, clearing warning noise for test log.

- Resolve issues arround broken type resolution in test files inside
  webap-core package
- Remove redunant React imports in test files
- Use correct testing library package for renderHook - remove conosle
  warnings
- Refresh nx pnpm patch to match new version
@emil-litwiniec emil-litwiniec marked this pull request as ready for review May 10, 2024 10:30
@emil-litwiniec emil-litwiniec merged commit 063a891 into master May 13, 2024
53 checks passed
@emil-litwiniec emil-litwiniec deleted the chore/update-nx branch May 13, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants