feat: allow the user to change membership role #515
Conversation
There was a problem hiding this comment.
@mskwierczynski Also please add some feedback to the user as we spoke
| import { render } from '../../../tests/utils/rendering'; | ||
| import { MembershipEntry } from './membershipEntry.component'; | ||
| import { updateTenantMembershipMutation } from './membershipEntry.graphql'; | ||
| import { membershipFactory, tenantFactory } from '@sb/webapp-tenants/tests/factories/tenant'; |
There was a problem hiding this comment.
use ../../../tests/factories/tenant;
|
|
||
| describe('MembershipEntry: Component', () => { | ||
| it('should commit update mutation', async () => { | ||
| jest.mock('react-router-dom', () => ({ |
There was a problem hiding this comment.
You con't need to use this. You can use the tenant id from the tenant passed to currentUserFactory.
There was a problem hiding this comment.
oh yes, that's right
| })); | ||
|
|
||
| render( | ||
| <CurrentTenantProvider> |
There was a problem hiding this comment.
Also there should be <CurrentTenantProvider/> already in test providers included so you don't need to wrap the component here.
mskwierczynski
force-pushed
the
feat/multi-tenancy-role-change
branch
from
004844c
to
b629d52
Compare
...rc/components/tenantMembersList/membershipEntry/__tests__/membershipEntry.component.spec.tsx
Show resolved
Hide resolved
| data, | ||
| })); | ||
|
|
||
| render(<MembershipEntry membership={membership} />, { |
There was a problem hiding this comment.
We are used to create a const Component = () => <MembershipEntry.../> in every test to we could easily reuse the component props between tests in each test file. Also would be good to add refetch param and check below if it is called after mutation
|
|
||
| export type MembershipEntryProps = { | ||
| className?: string; | ||
| membership: TenantMembershipType; | ||
| refetch?: () => void; |
There was a problem hiding this comment.
What do you think about changing this name to something more clear? Like onAfterUpdate?
There was a problem hiding this comment.
sure. will do
...ebapp-tenants/src/components/tenantMembersList/membershipEntry/membershipEntry.component.tsx
Show resolved
Hide resolved
mskwierczynski
force-pushed
the
feat/multi-tenancy-role-change
branch
from
b1f430a
to
17e08eb
Compare
mskwierczynski
force-pushed
the
feat/multi-tenancy-role-change
branch
from
7e80efb
to
e27d9db
Compare
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
New feature: membership role update.
What is the current behavior?
What is the new behavior?
Closes #514