fix: Prevent NX from loading .env files when running CLI scripts. #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkleszcz
reviewed
Feb 13, 2024
| @@ -48,6 +48,10 @@ export async function loadVersionEnv() { | |||
| return version; | |||
| } | |||
|
|
|||
| export const loadNxEnv = () => { | |||
There was a problem hiding this comment.
I don't like this name... It should be sth like disableNxEnv for example
There was a problem hiding this comment.
Hmm, ok. I was rather thinking it's a good place to put other NX-related envs in the future if necessary
mkleszcz
requested changes
Feb 13, 2024
mkleszcz
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
Closes #475
What is the current behavior?
NX loads .env files from webapp and backend packages when running CLI commands. Some of variables are interfering with the execution of the script. They should only be loaded by Docker or Vite during runtime of apps, not scripts.
What is the new behavior?
Patched
nxpackage to prevent this behaviour with an ENV variable set within CLI.Does this PR introduce a breaking change?
Not a breaking change but if someone used .env files in a wrong way that could cause conflict.